Closed
Bug 1505257
Opened 6 years ago
Closed 5 years ago
debug_SetCachedBoolPref asserts when nglayout.debug.paint_flashing_chrome is toggled
Categories
(Core :: Widget, defect, P5)
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: awilfox, Assigned: awilfox)
Details
Attachments
(1 file, 1 obsolete file)
951 bytes,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Toggling nglayout.debug.paint_flashing_chrome from about:config results in: [10495, Main Thread] ###!!! ASSERTION: cmon, this code is not reached dude.: 'false', file /var/clean/mozppc/mozilla-unified/widget/nsBaseWidget.cpp, line 3386 being logged to stderr on a debug build of Firefox. This appears to be because observing nglayout.debug.paint_flashing also matches the _chrome variant, and debug_PrefValues doesn't have nglayout.debug.paint_flashing_chrome as an item.
Assignee | ||
Comment 1•6 years ago
|
||
This patch quiets the assertion. The pref continues to work correctly when toggled.
Assignee | ||
Comment 2•5 years ago
|
||
Rebased patch with clang-format fixes.
Attachment #9023161 -
Attachment is obsolete: true
Attachment #9029312 -
Flags: review?(mstange)
Comment 3•5 years ago
|
||
Comment on attachment 9029312 [details] [diff] [review] Bug 1505257 - add nglayout.debug.paint_flashing_chrome to paint debug value list This code is ancient and fascinating. I think the only reason it kicks in here is the fact that the pref name "nglayout.debug.paint_flashing" is a prefix of the "nglayout.debug.paint_flashing_chrome" name, so the existing observer kicks in and is confused. So yeah, let's taking this patch to fix the assertion, but we really should just remove this whole chunk of unused debugging code.
Attachment #9029312 -
Flags: review?(mstange) → review+
Updated•5 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•5 years ago
|
||
I've filed bug 1512007 on removing this code.
Updated•5 years ago
|
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c84eefa8a511 add nglayout.debug.paint_flashing_chrome to paint debug pref value list r=mstange
Keywords: checkin-needed
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c84eefa8a511
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•