1505286 - [remote-dbg-next] Improve background/lazy tab support for USB runtimes

Status: VERIFIED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Background tab might not be the correct name here.

STRs to create some background/lazy tabs:
- open Firefox for Android
- open a few tabs on various URLs
- close Firefox for Android
- open Firefox for Android again
=> one tab should load, the other tabs are listed and have a preview but are actually not loaded yet. That's what I call background tabs here. (I think the same happens when you reopen firefox for desktop, tabs will wait to be focused before loading anything.

Now connect to the device using new about:debugging. Several things are currently incorrect for the background tabs:
- URL is about:blank
- clicking on inspect opens a toolbox that shows incorrect content (markup view has almost no markup, debugger has no sources etc...)

Either we can force loading such tabs, or we need to communicate to the user that the tabs need to be focused to be debugged first. Note that we have the same issue with WebIDE today.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1505286: Notify closing event on background tab. r=ochameau!,jdescottes!

For now, even when close the background/lazy tabs, could not reflect to
`about:debugging` page. In this patch, notify to DevTools clients when close
any tabs.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1505286 - Part 1: Show proper URL of zombie tab on Android. r=ochameau!,jdescottes!

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1505286 - Part 2: Unzombify tab on Android when the tab debugs. r=ochameau!,jdescottes!

Depends on D13223

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/755ac698de79
Part 1: Show proper URL of zombie tab on Android. r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/fd04a73e9732
Part 2: Unzombify tab on Android when the tab debugs. r=ochameau,jdescottes

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/755ac698de79
https://hg.mozilla.org/mozilla-central/rev/fd04a73e9732

Comment 6

[Hani Yacoub, Desktop QA]

Could you please provide some examples of some background/lazy tabs?

Comment 7

[Julian Descottes [:jdescottes]]

The summary contains STRs to create such tabs:

STRs to create some background/lazy tabs:
- open Firefox for Android
- open a few tabs on various URLs
- close Firefox for Android
- open Firefox for Android again
=> one tab should load, the other tabs are listed and have a preview but are actually not loaded yet. That's what I call background tabs here. (I think the same happens when you reopen firefox for desktop, tabs will wait to be focused before loading anything.

Basically open a bunch of tabs on Fx for Android, close and reopen Fx for Android. All the tabs except the displayed one will be lazy.

Comment 8

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 68.0a1 (2019-04-01), Firefox 67.0b6 and Firefox 66.0.2 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.