Closed Bug 1505286 Opened 2 years ago Closed 2 years ago

[remote-dbg-next] Improve background/lazy tab support for USB runtimes

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox66 verified, firefox67 verified, firefox68 verified)

VERIFIED FIXED
Firefox 66
Tracking Status
firefox66 --- verified
firefox67 --- verified
firefox68 --- verified

People

(Reporter: jdescottes, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Background tab might not be the correct name here.

STRs to create some background/lazy tabs:
- open Firefox for Android
- open a few tabs on various URLs
- close Firefox for Android
- open Firefox for Android again
=> one tab should load, the other tabs are listed and have a preview but are actually not loaded yet. That's what I call background tabs here. (I think the same happens when you reopen firefox for desktop, tabs will wait to be focused before loading anything.

Now connect to the device using new about:debugging. Several things are currently incorrect for the background tabs:
- URL is about:blank
- clicking on inspect opens a toolbox that shows incorrect content (markup view has almost no markup, debugger has no sources etc...)

Either we can force loading such tabs, or we need to communicate to the user that the tabs need to be focused to be debugged first. Note that we have the same issue with WebIDE today.
See Also: → 1505287
Priority: -- → P2
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
Priority: P2 → P1
For now, even when close the background/lazy tabs, could not reflect to
`about:debugging` page. In this patch, notify to DevTools clients when close
any tabs.
Attachment #9027454 - Attachment is obsolete: true
Attachment #9028232 - Attachment description: Bug 1505286 - Part 2: Unzombify in case inspect zombie tab on Android. r=ochameau!,jdescottes! → Bug 1505286: Unzombify zombie tabs on Android when the actor connect to the browser.
Attachment #9028231 - Attachment is obsolete: true
Attachment #9028231 - Attachment is obsolete: false
Attachment #9028232 - Attachment description: Bug 1505286: Unzombify zombie tabs on Android when the actor connect to the browser. → Bug 1505286 - Part 2: Unzombify tab on Android when the tab debugs. r=ochameau!,jdescottes!
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/755ac698de79
Part 1: Show proper URL of zombie tab on Android. r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/fd04a73e9732
Part 2: Unzombify tab on Android when the tab debugs. r=ochameau,jdescottes
https://hg.mozilla.org/mozilla-central/rev/755ac698de79
https://hg.mozilla.org/mozilla-central/rev/fd04a73e9732
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Could you please provide some examples of some background/lazy tabs?

Flags: needinfo?(jdescottes)

The summary contains STRs to create such tabs:

STRs to create some background/lazy tabs:
- open Firefox for Android
- open a few tabs on various URLs
- close Firefox for Android
- open Firefox for Android again
=> one tab should load, the other tabs are listed and have a preview but are actually not loaded yet. That's what I call background tabs here. (I think the same happens when you reopen firefox for desktop, tabs will wait to be focused before loading anything.

Basically open a bunch of tabs on Fx for Android, close and reopen Fx for Android. All the tabs except the displayed one will be lazy.

Flags: needinfo?(jdescottes)

Verified as fixed on Firefox Nightly 68.0a1 (2019-04-01), Firefox 67.0b6 and Firefox 66.0.2 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.