Closed
Bug 1505291
Opened 6 years ago
Closed 6 years ago
Port bug 1504725 to TB: Error when trying to restart into new language on Beta
Categories
(Thunderbird :: Preferences, task)
Tracking
(thunderbird64 fixed, thunderbird65 fixed)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
2.26 KB,
patch
|
jorgk-bmo
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
From comment 0: Nothing happens when clicking the "Apply and restart" button after switching browser languages on Beta. There is an error in the console: ReferenceError: event is not defined And comment 6: Just got the mozregression working, tracked it down to bug 1493869. So having this work on Nightly but not Beta is expected but sounds like this bug could easily happen again.
Assignee | ||
Comment 1•6 years ago
|
||
Port of https://hg.mozilla.org/mozilla-central/rev/84367a375806
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9023188 -
Flags: review?(jorgk)
Attachment #9023188 -
Flags: approval-comm-beta?
Comment 2•6 years ago
|
||
Comment on attachment 9023188 [details] [diff] [review] 1505291-language-event.patch You need to type - bug 1504725 comment #0 - and - bug 1504725 comment #6 - for this to work ;-) Thanks for watching C-C activities!!
Attachment #9023188 -
Flags: review?(jorgk)
Attachment #9023188 -
Flags: review+
Attachment #9023188 -
Flags: approval-comm-beta?
Attachment #9023188 -
Flags: approval-comm-beta+
Assignee | ||
Comment 3•6 years ago
|
||
I know, but when I quote the whole comment I thought it's not needed to link completely.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/29dbc84a0a79 Port bug 1504725 to TB: Explicitly pass event to language change handler. r=jorgk DONTBUILD
Comment 5•6 years ago
|
||
I've pushed this now since we may have a Daily/Nightly build again today. We'll see.
Target Milestone: --- → Thunderbird 65.0
Version: 60 → 64
Comment 6•6 years ago
|
||
Beta (TB 64 beta 2): https://hg.mozilla.org/releases/comm-beta/rev/82128d3a84df8702c394ce16ad4560ddba8dad3a
status-thunderbird64:
--- → fixed
status-thunderbird65:
--- → fixed
Updated•5 years ago
|
Type: defect → task
You need to log in
before you can comment on or make changes to this bug.
Description
•