Remove unused netmonitor webpack config as well as devtools/shared/webpack
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: ochameau, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
The netmonitor is no longer supporting its launchpad/webpack setup and it seems to be the only used of the whole devtools/shared/webpack folder: https://searchfox.org/mozilla-central/search?q=shared%2Fwebpack&case=true®exp=false&path= So I imagine we can get rid of all of that.
Updated•6 years ago
|
Comment 1•5 years ago
|
||
Need to remove these files also?
https://searchfox.org/mozilla-central/source/devtools/client/shared/webpack
Reporter | ||
Comment 2•5 years ago
|
||
Yes.
As well as:
devtools/client/netmonitor/webpack.config.js
And a reference here:
https://searchfox.org/mozilla-central/source/.eslintignore#104
And some other stuff also related to launchpad:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/yarn.lock
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/webpack.config.js
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/bin
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/launchpad.js
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/package.json
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/.babelrc
And this section of the README:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/README.md#17-27
For the patch, I would suggest asking the review to :Honza to double check.
Reporter | ||
Comment 3•5 years ago
|
||
The whole "bin" and "configs" folders should be removed.
Updated•5 years ago
|
Updated•5 years ago
|
Hello Jan,
I would like to work on this.
Could it be assigned to me?
Thanks!
Comment 5•5 years ago
|
||
Looks like this is no longer valid. Could you close this ?
Comment 6•5 years ago
|
||
Correct, this has been already done.
Thanks for the note!
Honza
Description
•