Closed Bug 1505318 Opened Last year Closed Last year

Port bug 1503022 to TB: Refactor window and toolbar color handling and make the Dark and Light themes honor the Windows 10 accent color setting

Categories

(Thunderbird :: Theme, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1503022 made some rules simpler by moving some variables to the content CSS file. On Windows 10 the dark and light themes don't paint the whole tabbar background (in drawInTitlebar mode) when the accent colour is applied to the titlebar.
There should be no difference to before except when in drawInTitlebar mode on Win10 the accent colour is applied to the titlebars, the tabbar shows the accent colour instead the full black or light grey colour.

I also ported bug 1503304 which landed some minutes ago.

The m-c changesets are:
bug 1503022: https://hg.mozilla.org/mozilla-central/rev/a672ddc3be9f
bug 1503304: https://hg.mozilla.org/mozilla-central/rev/6ea314ab963f
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9023217 - Flags: review?(jorgk)
I think the Windows accent colour gets used too much now.

With no menu, only the active tab is drawn in the "regular" colour, all others and the "tab free" area is drawn in the accent colour. Personally, I'd only draw the "tab free" area in accent colour.

If you enable the menu, you get the menu in the accent colour plus all the non-active tabs. That's too much, no? Is that what FF does?
Comment on attachment 9023217 [details] [diff] [review]
1505318-Win10-accent-color.patch

OK, I tried a FF Nightly. Too much accent colour! But we follow that :-(
Attachment #9023217 - Flags: review?(jorgk) → review+
We could do it like on Windows 7 where the inactive tabs have also the theme background colour. What do you think? If yes, I'll try it in a new bug.
Keywords: checkin-needed
Yes, please.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1259dd18be66
Port bug 1503022 to TB: Refactor window and toolbar color handling and make the Dark and Light themes honor the Windows 10 accent color setting. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Version: 60 → Trunk
Type: defect → task
You need to log in before you can comment on or make changes to this bug.