1505377 - Msi configured properties do not work together

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Peter Magyari (Desktop QA)]

[Description]:
Set a directory path - /INSTALL_DIRECTORY_PATH=[path]
Absolute path specifying the complete install location. This directory does not need to exist already (but it can).
If InstallDirectoryName is set, then this setting will be ignored.

Set a directory name - /INSTALL_DIRECTORY_NAME=[name]
Name of the installation directory to create within Program Files. For example, if InstallDirectoryName is set to Firefox Release, then the installation path will be something like C:\Program Files\Firefox Release. The Program Files path used will be the correct one for the architecture of the application being installed and the locale/configuration of the machine; this setting is mainly useful to keep you from having to worry about those differences.
If this is set, then InstallDirectoryPath will be ignored.

Set a file extraction directory - /EXTRACT_DIR=[directory]
Extract the application files to the given directory and exit, without actually running the installer. Of course, this means all other options will be ignored.

[Affected platforms]:
-Windows 7(32x/64x)
-Windows 8.1(32x/64x)
-Windows 10(32x/64x)

[Steps to reproduce]:
1.Run Orca.exe
2.File->Open and select the MSI to be edited.
3.Find the Property table and select it.
4.Modify INSTALL_DIRECTORY_PATH to something like "C:\Test".
5.Modify INSTALL_DIRECTORY_NAME to something like "DirectoryName".
6.Modify EXTRACT_DIR to something like "C:\Random_extractdir and focus away".
7.Click on File->Save as to save your new msi file.
8.Run the above configured MSI with: msiexec.exe /i "c:\Msi\test.msi"

[Expected result]:
Not sure what the expected results would be in this case.

[Actual result]:
Firefox gets installed in the default "c:\Program Files\Firefox..." Path.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

I think what happened here is a consequence of bug 1504244. When EXTRACT_DIR is set it always "wins" and the other options are ignored, but because of bug 1504244 EXTRACT_DIR doesn't work, so the end result is that none of the directory properties are used at all and you get the default path whenever EXTRACT_DIR is set.

I'm not closing this bug right now because we need to validate my theory by testing this again after bug 1504244 lands.

Comment 2

[:shell escalante]

Who should we ask to verify your theory - since bug 1504244 landed?

Comment 3

[Molly Howell (she/her) (mostly inactive)]

Adrian, can we get this bug re-tested? I think it should have been fixed by bug 1504244.

Comment 4

[Peter Magyari (Desktop QA)]

I've verified it, the hierarchy is working as intended after Bug 1504244 landed (EXTRACT_DIR > DIRECTORY_NAME > DIRECTORY_PATH)

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Okay, great; thanks, Peter.