Closed Bug 1505484 Opened 6 years ago Closed 5 years ago

tabbar with new tab button overflows into window control buttons/icons like minimize, maximize and restore windowed mode

Categories

(Firefox :: Theme, defect, P1)

Unspecified
Windows 8.1
defect

Tracking

()

VERIFIED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- unaffected
firefox65 --- verified

People

(Reporter: aryx, Assigned: mconley)

References

Details

(Keywords: regression)

Attachments

(3 files)

Firefox Nightly 65.0a1 on Windows 8.1

Bisection show it as regression from bug 1356920.

If the tab bar doesn't provide enough space to show all tabs at once, the tab bar will overflow with its 'new tab' button (and also the list of open tabs if added) into the window controls like 'maximize' and 'minimize'.
Flags: needinfo?(dao+bmo)
Component: Tabbed Browser → Theme
Flags: needinfo?(dao+bmo) → needinfo?(mconley)
Keywords: regression
Priority: -- → P1
Assignee: nobody → mconley
Flags: needinfo?(mconley)
OS: Unspecified → Windows 8.1
I'm waiting on a license for Windows 8.1 so I can reproduce and debug this.
I've got Windows 8.1 set up, and can reproduce the problem. Starting investigations.
It turns out that the titlebar button rules on Windows 8.1 are more different than the Windows 10 rules than I expected. :/ On Windows 8.1, -moz-window-buttonbox and -moz-window-buttonbox-maximized are used to draw the titlebar buttons, much the way that's done with Windows 7 Aero.

As an added bonus, the buttons bring a background colour with them (the titlebar colour), so in order to not have it overlap the navbar top border, nor look absolutely horrible with a lightweight theme enabled, I have to shrink-wrap the buttons.

Setting display: flex on the container seems to do the job, although setting max-height: 0px; on the buttonbox would also do it. I don't have a preference.
The issue is reproducible on Win 8.0 x32 also. Tried on Win 7 and 10 but couldn't reproduce.
(In reply to Mike Conley (:mconley) (:⚙️) from comment #5)
> It turns out that the titlebar button rules on Windows 8.1 are more
> different than the Windows 10 rules than I expected. :/ On Windows 8.1,
> -moz-window-buttonbox and -moz-window-buttonbox-maximized are used to draw
> the titlebar buttons, much the way that's done with Windows 7 Aero.
> 
> As an added bonus, the buttons bring a background colour with them (the
> titlebar colour), so in order to not have it overlap the navbar top border,
> nor look absolutely horrible with a lightweight theme enabled, I have to
> shrink-wrap the buttons.

Does bug 1506190 help with the nav bar top border problem?
Flags: needinfo?(mconley)
(In reply to Dão Gottwald [::dao] from comment #8)
> Does bug 1506190 help with the nav bar top border problem?

Yes, it does! It, however, doesn't help with the background colour problem. I'll attach a screenshot of the issue.
Attached image With LWT
Flags: needinfo?(mconley)
Flags: needinfo?(dao+bmo)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/215c8cda44fe
Fix titlebar button rendering on Windows 8.1. r=dao
https://hg.mozilla.org/mozilla-central/rev/215c8cda44fe
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
(In reply to Mike Conley (:mconley) (:⚙️) from comment #11)
> Created attachment 9025078 [details]
> With LWT

I'm still noticing this in the most recent build of 65a even though the buttons themselves are at least back. Is there another bug I should be following for progress on fixing this? It's been a bug in FF on Windows 8 for years and I was super eager to see that taken care of at last.
In dialog "Clear history" buttons OK, Cancel - not shown.
screenshot: https://fastpic.co/image/h5EOaE
Windows 8.1 64 bit
Reproducible on Windows 8/8.1

STR:
1. Start Firefox
2. Open at least 5 new tabs
3. Look at the + button position
Flags: qe-verify+

I have managed to reproduce this issue on an affected Firefox 65.0a1 (20181107220128) build using Windows 8.1 x64.

This issue is verified fixed using Firefox 66.0a1 (20190120213632) and Firefox 65.0b12 on Windows 8.1 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: