1505488 - Log viewer fills history with many entries making it hard to go back

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

STR:
- Click on a logviewer link from an intermittent failure bug. e.g. in bug 1505448 there is this link: https://treeherder.mozilla.org/logviewer.html#?job_id=210341200&repo=mozilla-inbound
- Click back

Expected:
- Back to the bug

Actual:
- No visible change. Holding down the back button shows that there are 5(!) logviewer entries which IMO is 4 too many in this case.

Comment 1

[Ed Morley [:emorley]]

Hi!

The log viewer has just been rewritten in bug 1450045. 

This change is currently only on stage - trying it out there the situation appears to be improved slightly - only 1 additional history entry instead of 4. The extra entry appears to be due to the log viewer automatically highlighting the first error line if no error line permalink was specified in the URL.

It seems like there are two things that we might want to fix:
1) Don't leave history entries when adjusting the highlight on initial load
2) Make the intermittent failures view link to the specific error line (I think it has this information already?), which would help in cases where there are multiple errors and only one is the relevant one.

Comment 2

[Ed Morley [:emorley]]

(stage is https://treeherder.allizom.org )

Comment 3

[Sarah Clements [:sclements]]

(In reply to Ed Morley [:emorley] from comment #1)

> It seems like there are two things that we might want to fix:
> 1) Don't leave history entries when adjusting the highlight on initial load
> 2) Make the intermittent failures view link to the specific error line (I
> think it has this information already?), which would help in cases where
> there are multiple errors and only one is the relevant one.

The intermittent failures view `bugdetails` page contains these details in the Log column: total count of unexpected-fails with a preview of the line when the user hoovers over the column. The `details` link goes right to the highlighted line(s).

Comment 4

[Ed Morley [:emorley]]

Not for me...

<a class="small-text" href="logviewer.html#?job_id=210071352&amp;repo=mozilla-inbound" target="_blank" rel="noopener noreferrer">view details</a>

Comment 5

[Sarah Clements [:sclements]]

(In reply to Ed Morley [:emorley] from comment #4)
> Not for me...
> 
> <a class="small-text"
> href="logviewer.html#?job_id=210071352&amp;repo=mozilla-inbound"
> target="_blank" rel="noopener noreferrer">view details</a>

It's not done programmatically in IFV, but it looks like Logviewer is adding a query param with the first error line to the url. If you click on a bug number from IFV (on stage or prod), then click on the 'view details' in the log column you should see that behavior. Or am I misunderstanding something?

Comment 6

[Ed Morley [:emorley]]

The logviewer internally redirecting to add that line number to the URL is what adds another entry to the history. Adjusting the URL used by IFV would skip having to perform that "redirect".

Comment 7

[Sarah Clements [:sclements]]

Ah, I see what you mean. I'll make a change and submit.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I this got fixed at some point, doesn't seem to be an issue any more.