Closed Bug 1505535 Opened 10 months ago Closed 5 months ago
Add tab usage probes for pinned tabs
We do not have probes implemented for measuring "who uses pinned tabs". We have data on users that *restore* pinned tabs (https://telemetry.mozilla.org/probe-dictionary/?search=pinn), however this only fires for uses that restore a session. Having the general case will make targeting and promoting this feature to users (who don't use the feature) more straight forward. I'm requesting we "duplicate" the engagement probes we have for tabs for pinned tabs as well: https://telemetry.mozilla.org/probe-dictionary/?search=tab&detailView=scalar%2Fbrowser.engagement.max_concurrent_tab_count https://telemetry.mozilla.org/probe-dictionary/?search=tab&detailView=scalar%2Fbrowser.engagement.tab_open_event_count i.e. browser.engagement.max_concurrent_pinned_tab_count, browser.engagement.pinned_tab_event_count
Component: Telemetry → Tabbed Browser
Product: Toolkit → Firefox
Component: Tabbed Browser → General
Product: Firefox → Data Platform and Tools
Assignee: nobody → andrei.br92
Attachment #9052198 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 9052198 [details] datareview I'm afraid it's a data-review- at first. Permanent collections require a person mentioned in the review request who will be responsible for the collection over time. Also, the answer to question 5 is incomplete. We need a list of the measurements (there are two) and their Data Collection Categories. (Please follow the instructions on the [Data Collection wiki](https://wiki.mozilla.org/Firefox/Data_Collection) and the [Data Review Request](https://github.com/mozilla/data-review/blob/master/request.md)) I think those are the only two things. When you have those handled please re-request review with the updated request and I'll give it another look-over.
Attachment #9052198 - Flags: data-review?(chutten) → data-review-
Product: Data Platform and Tools → Firefox
Comment on attachment 9053224 [details] datareview.txt Can you have another look? Thank you.
Attachment #9053224 - Flags: feedback?(chutten)
Comment on attachment 9053224 [details] datareview.txt Preliminary note: Ben's listed on the review request as the monitor for these probes, but his email isn't included in the list of `notification_emails` in the Scalars definitions. It is a good idea to have the monitor be present in that list. DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? Yes, :bmiroglio is responsible. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 2, Interaction. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? No. This collection is permanent. --- Result: datareview+
Attachment #9053224 - Flags: feedback?(chutten) → data-review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8f97eb6d4071 Add tab usage probes for pinned tabs r=janerik
https://hg.mozilla.org/projects/ash/rev/8f97eb6d4071b54382473d7eabe762fe4d9a4f80 Bug 1505535 - Add tab usage probes for pinned tabs r=janerik
You need to log in before you can comment on or make changes to this bug.