Closed Bug 1505604 Opened 2 years ago Closed 2 years ago

Remove enum class ReaderMode from Stream.cpp

Categories

(Core :: JavaScript Engine, enhancement)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

Bug 1505604 - Remove enum class ReaderMode from Stream.cpp. r?tcampbell
47 bytes, text/x-phabricator-request
Details | Review 
No description provided.
For all I know we might want this again someday, when we re-implement byte-oriented streams. Let's cross that bridge when we come to it.
Note also: we've already got JS::ReadableStreamReaderMode. It doesn't make a lot of sense to have two of these.
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a0db4fb071c
Remove enum class ReaderMode from Stream.cpp. r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/7a0db4fb071c
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee: nobody → jorendorff
You need to log in before you can comment on or make changes to this bug.