Closed Bug 1505666 Opened 10 months ago Closed 9 months ago

testGCUniqueId tests GC moving in the wrong order

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: pbone, Assigned: pbone)

References

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/source/js/src/jsapi-tests/testGCUniqueId.cpp#97-118

This code:

 1. Allocates an array of things.
 2. Punches holes in the array making some things unreachable.
 3. Does a GC that might compact
 4. Chooses and object and takes its address
 5. Does a compacting GC
 6. Compares the objects's old and new pointers expecting it to move.

However if the first GC was a compacting GC then the object will have moved then and won't move in the 2nd compacting GC.
Assignee: nobody → pbone
Status: NEW → ASSIGNED
Attachment #9023515 - Flags: review?(jcoppeard)
Attachment #9023515 - Flags: review?(jcoppeard) → review-
Attachment #9023515 - Flags: review- → review+
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7705516c1e3
Fix order of operations in the testGCUniqueId test r=jonco
https://hg.mozilla.org/mozilla-central/rev/c7705516c1e3
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.