Closed Bug 1505679 Opened 7 years ago Closed 7 years ago

HTMLEditor::RemoveList() should set different EditAction for <ol>, <ul> and the others

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

HTMLEditor::RemoveList() currently sets EditAction::eRemoveListElement. However, "insertOrderedList" or "insertUnorderedList" needs to be set into InputEvent.inputType.
Even when execCommand("insertorderedlist") and execCommand("insertunorderedlist") remove existing lists, we need to set InputEvent.inputType value to "insertOrderedList" or "insertUnorderedList". Fortunately, the XPCOM method is used only for handling execCommand("insertorderedlist") and execCommand("insertunorderedlist") on Firefox. Therefore, we should make it set EditAction to EditAction::eRemoveOrderedListElement or EditAction::RemoveUnorderedListElement. Note that comm-central uses this method directly and uses "cmd_removeList" which causes calling the XPCOM method with empty string. However, input events for them won't be exposed to the web. Therefore, it's okay to set EditAction::eRemoveListElement for the other cases.
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/95bd81205750 Make HTMLEditor::RemoveList() sets specific EditAction when it's called by execCommand("insertorderedlist") or execCommand("insertunorderedlist") r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: