1505707 - Unhandled rejection in browser/components/payments/res/containers/{address-form.js,basic-card-form.js}

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/6e0e603f4852b8e571e5b8ae133e772b18b6016e/browser/components/payments/res/containers/address-form.js#88-89
>   connectedCallback() {
>     this.promiseReady.then(form => {
>       this.body.appendChild(form);
> ...
>     });
>   }

form there can be null for some case (not yet checked)

after applying bug 1498775 patch (which adds more error report for unhandled rejection), the test fails.
same for basic-card-form.js

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Handle error case in browser/components/payments/res/containers/{address-form.js,basic-card-form.js}.

Changing the connectedCallback method to async and propagate the error to caller makes the test really fails.
after that, added null-check.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 9023543 [details] [diff] [review]
Handle error case in browser/components/payments/res/containers/{address-form.js,basic-card-form.js}.

Review of attachment 9023543 [details] [diff] [review]:
-----------------------------------------------------------------

Where did you see this fail? Which tests? `form` should never be null so I'd rather fix the test than change this.

Comment 3

[Tooru Fujisawa [:arai]]

Sorry, forgot to link
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dcd08bde30eb73cf21ff93b0403f740a5eea4e6&selectedJob=210514993

it's a try with bug 1498775 patch (and some other patch to fix failure discovered by that)

Comment 4

[Matthew N. [:MattN]]

OK, so the issue is in test_payer_address_picker.html it seems. I think there may be a simple fix.

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1505707 - Sandbox the template frame for payment mochitests to prevent JS execution errors. r?jaws

We only want the frame to be able to share markup, we don't need JS to execute and the JS was causing an unhandled rejection error.

Comment 6

[Matthew N. [:MattN]]

arai, can you confirm the patch fixes the issue?

Comment 7

[Tooru Fujisawa [:arai]]

Thanks! The error doesn't happen with the patch applied locally
(for me, the test harness somehow doesn't finish, and cannot check if it reports, so I directly checked the error in web console)
I'll check on try shortly.

Comment 8

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cc8715a747403003d8e33cf6abc49052fff8df2&group_state=expanded
yeah, it's fixed

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cab9a968094
Sandbox the template frame for payment mochitests to prevent JS execution errors. r=jaws

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7cab9a968094