Closed Bug 1505720 Opened 2 years ago Closed 1 year ago

crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)]

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 66
Tracking Status
firefox64 --- wontfix
firefox65 --- verified
firefox66 --- verified

People

(Reporter: mirabela.lobontiu, Assigned: andrei.a.lazar)

References

()

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

Attached file logcat
Device:
 - Sony Xperia Z5 Premium (Android 6.0.1);
 
Build(s):
 - Nightly 65.0a1 (2018-11-07);
 - Release 63.0.2.

Steps to reproduce:
 1. Go to Settings -> Sign in, and sign in with valid credentials.
 2. Go to Settings -> you FxA and Disconnect
 3. Nightly crashes

Expected result:
 The user should be disconnected.

Actual result:
 Nightly crashes.
See Also: → 1349147
Hi,

I reproduced the crash on Nightly 65.0a1 (2018-11-08) on Samsung Galaxy Note 8 (Android 8.0).

crash signature: [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java) ]
If we crash every time people log out of accounts we should set this as a P1 to investigate. 
It doesn't look like a huge crash volume on release, but it's significant.
Priority: -- → P1
Assignee: nobody → andrei.a.lazar
Refreshing account (triggered by signing in) can cause a NullPointerException after quickly signing out.
This defect consists in bad sync between the signing in state and signing out state.
Request from Janet to find a proper reviewer.
Flags: needinfo?(jdragojevic)
Hi,
I have just reproduced the crash with this id on the Sony Xperia Z5 with Android 7.0 on Fennec 64.0.1 - build id: 20181213132357
https://crash-stats.mozilla.com/report/index/aed7858f-d040-44da-96a6-edeba0181214#tab-details
@Susheel - both Edourard and Nick Alexander provided reviews for this fix.  

@Alexandru, it's unclear to me whether you reproduced this issue before or after the fix was merged.  

@Susheel, I'm NI'ing back to you to follow up on the details here.
Flags: needinfo?(jdragojevic) → needinfo?(sdaswani)
Hey Janet, I am still working on this, nothing has been merged. Will make requested changes ASAP
Thanks Janet, Andrei is working on it so removing my NI until further 'needed' :) .
Flags: needinfo?(sdaswani)
Keywords: checkin-needed

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfdec6abcc4d
crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)] r=Grisha

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Blocks: 1508600

Can you request uplift to 65 beta? It seems worth doing as it's ~1000 crashes/week on release.

Flags: needinfo?(andrei.a.lazar)

Sure Liz, will do.

Flags: needinfo?(andrei.a.lazar)

Comment on attachment 9030774 [details]
Bug 1505720 crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)] r=JanH

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1505720

User impact if declined: Will continue to cause a lot of crashes.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): It is a bit risky because it impacts a pretty complex component.

String changes made/needed:

Attachment #9030774 - Flags: approval-mozilla-beta?

Comment on attachment 9030774 [details]
Bug 1505720 crash [@ java.lang.NullPointerException: at org.mozilla.gecko.fxa.authenticator.AndroidFxAccount.renameAccountIfNecessary(AndroidFxAccount.java)] r=JanH

[Triage Comment]
Hard to tell how much difference it's made on Nightly so far, but looks low-risk enough. Let's get it into 65.0b11 to see if there's a clearer improvement.

Attachment #9030774 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Tested on latest Nightly build (66.0a1- 2019/01/14) and Beta 65.0b11 with the affected devices:

  • Sony Xperia Z5 Premium (Android 6.0.1) and
  • Samsung Galaxy Note 8 (Android 8.0.0)
    Following the steps provided by Mira I couldn't reproduce the issue and I will set the bug to VERIFIED.
Status: RESOLVED → VERIFIED
No longer blocks: 1508600
See Also: → 1508600
See Also: → 1588071
You need to log in before you can comment on or make changes to this bug.