1505748 - In the Language switcher dialog the "Add" button doesn't work if you use the "Enter" key

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[ovidiu boca[:Ovidiu]]

[Affected versions]:

Tested on Nightly 65.0a1

[Affected platforms]:

Mac OS X 

[Steps to reproduce]:

1. Open "Preferences" and go to the "Language" section
2. Use the "Tab" key to focus the language drop-down from "Choose the languages used to display menus, messages, and notifications" section
3. Use the down arrow key and select "Search for more languages..." and click "Enter"
4. Using the "Tab" key focus the "Select a language to add..." drop-down and select a language 
5. Using the "Tab" key focus the "Add" button and press "Enter"


[Expected result]:

The language pack is added.

[Actual result]:

The dialog window is closed. 


[Additional notes]:

I also tested on Windows 10 and Ubuntu 16.04 and the issue can't be reproduced.

Comment 1

[ovidiu boca[:Ovidiu]]

One correction for step 3: Use the down arrow key and select "Search for more languages..." and press "Enter"

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(your comment #1 is the same line as the one in comment #0)

I looked at the code here and don't understand why this wouldn't work on OSX. I originally thought that maybe you needed to use Space to press the button but since the other buttons worked with Enter then that would be odd.

Can you use mozregression to find if this ever used to work?

Comment 3

[ovidiu boca[:Ovidiu]]

(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #2)
> (your comment #1 is the same line as the one in comment #0)

In the first comment, I wrote: "click Enter". In the second one I did the correction: "Press Enter".

> Can you use mozregression to find if this ever used to work?
I will look over this and I will update with the results, I will leave the NI? as a reminder.

Comment 4

[ovidiu boca[:Ovidiu]]

I reproduced this issue with Fx 63 release and Firefox 64 Beta 8, I also tested with Fx 62 and Fx 60 (using the same profile with all the preferences set up) and I can't test this because the feature is not implemented.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Does the Space key work to press the button?

Comment 6

[ovidiu boca[:Ovidiu]]

It works with "Space" key.

Comment 7

[:Gijs (he/him)]

(In reply to ovidiu boca[:Ovidiu] from comment #6)
> It works with "Space" key.

This is by design on macOS, and the same thing is true on other buttons in the preferences.