1505751 - The "Search for more languages..." option can be open if you use the "Enter" keyboard on Windows

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[ovidiu boca[:Ovidiu]]

Attachment: 2018-11-BUGGGGGGGGGGGGGGGGGGGGGGGGGGGGG.png

[Affected versions]:

Tested on Nightly 65.0a1

[Affected platforms]:

Windows 10

[Steps to reproduce]:

1. Open "Preferences" and go to the "Language" section
2. Use the "Tab" key to focus the language drop-down from "Choose the languages used to display menus, messages, and notifications" section
3. Use the down arrow key and select "Search for more languages..." and press "Enter"


[Expected result]:

The Language Settings window is open.

[Actual result]:

The language drop-down remains open. 


[Additional notes]:

I also tested on Mac OS and Ubuntu 16.04 and the issue can't be reproduced.

Comment 1

[Mark Striemer [:mstriemer]]

I can't get the list to open on Windows with the keyboard. Pressing down or up just changes what the selected item is in the list, pressing enter is treated as clicking "OK" in the dialog. I see the same behaviour in the web languages dialog.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I'm a bit lost with how to reproduce this. I realize now that I have to set intl.multilingual.enabled to true in order to expose the dropdown mentioned in comment 0. Are there other things one must do to reproduce this?

Ovidiu, can you please describe how to reproduce this issue from the perspective of someone who has just created a new profile?

Comment 3

[ovidiu boca[:Ovidiu]]

Hi Mike, here are the prerequisites:

Set the following preferences from about:config

intl.multilingual.enabled - set to TRUE
intl.multilingual.downloadEnabled - set to TRUE
Go to extensions.getAddons.langpacks.url and past the following link: https://mock-amo-language-tools.glitch.me/ This server provides language packs for Nightly.
extensions.langpacks.signatures.required -set to FALSE
Restart the browser.

Comment 4

[:Gijs (he/him)]

(In reply to Mark Striemer [:mstriemer] from comment #1)
> I can't get the list to open on Windows with the keyboard. Pressing down or
> up just changes what the selected item is in the list, pressing enter is
> treated as clicking "OK" in the dialog. I see the same behaviour in the web
> languages dialog.

Same here. However, if I press down to get to 'search for more languages...', the dialog opens automatically. That seems surprising to me...

If I use alt-down to bring up the dropdown, and then arrow down to select 'search for more languages...', it opens without pressing 'enter', and the dropdown does remain open, and overlaps the dialog.

:Ovidiu, can you clarify your steps?

Mark, can you check if there's something we can do about the popup remaining open and/or the keyboard navigation? Thanks.

Comment 5

[ovidiu boca[:Ovidiu]]

Sorry for the confusion, I logged this bug from Mac and the behavior is different there, here are the STR:


Preconditions: 
Set the following preferences from about:config

intl.multilingual.enabled - set to TRUE
intl.multilingual.downloadEnabled - set to TRUE
Go to extensions.getAddons.langpacks.url and past the following link: https://mock-amo-language-tools.glitch.me/ This server provides language packs for Nightly.
extensions.langpacks.signatures.required -set to FALSE
Restart the browser.

STR:
1. Open "Preferences" and go to the "Language" section
2. Use the "Tab" key to focus the language drop-down from "Choose the languages used to display menus, messages, and notifications" section
3. Press Alt + down arrow key and then navigate to "Search for more languages..."

[Expected result]:

The Language Settings window is open.

[Actual result]:

The Language Settings window is open and also the language drop-down remains open. 

Note: This issue is more obvious if you add more languages to the drop-down.

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: Bug 1505751 - Wait for menulist close for browser language handlers r?jaws

The search handler was being called when focusing the menuitem with the keyboard on Windows. This didn't provide a good experience and left the popup open once the search started. Ensure the popup is always shown when using the keyboard and don't trigger the search until the popup is closed.

Comment 7

[Mark Striemer [:mstriemer]]

I haven't tested this patch outside of Windows yet, but perhaps this is a better experience on Windows. It does change what normally happens when using the keyboard for navigation though.

This updates the handler to open the popup when a command is triggered (this might need to change for non-Windows) so that it mimics the MacOS behaviour. This then requires that you make a selection with Enter or Esc to trigger the command. Opening the popup isn't necessarily needed to fix this, it could trigger right away when not open and wait for it to close if it is already open.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c18244a41538
Wait for menulist close for browser language handlers r=Gijs

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/c18244a41538

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 11

[Mark Striemer [:mstriemer]]

This is still behind a pref for 64, going to wontfix it there. I don't think we need this fixed to properly test the related feature on release.

Comment 12

[ovidiu boca[:Ovidiu]]

Tested on Windows 10 x64 with FF Nightly 65.0a1(2018-11-27) and I can confirm the fix.