1505784 - Clean up script flags handling in XDRScript/CopyScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jan de Mooij [:jandem]]

Now that we use flag words for this, we no longer have to copy each flag explicitly in CopyScript and XDRScript.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1505784 part 1 - Copy immutableFlags_ word in CopyScript instead of copying each flag separately. r?tcampbell

Note: the old code didn't copy the HasNoScriptRval and SelfHosted flags, because
they are set to the correct values in CreateEmptyScriptForClone. That means it's
fine to copy them as part of the flags word.

The only change in behavior is that we now copy the IsLikelyConstructorWrapper
flag as well.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1505784 part 2 - Copy immutableFlags_ word in XDRScript instead of copying each flag separately. r?tcampbell

Depends on D11325

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1505784 part 2 - Move HideScriptFromDebugger from ImmutableFlags to MutableFlags. r?tcampbell

Depends on D11325

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1505784 part 3 - Copy immutableFlags_ word in XDRScript instead of copying each flag separately. r?tcampbell

Depends on D11335

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1505784 part 4 - Remove some now-redundant initialization code in JSScript::initFromModuleContext. r?tcampbell

Depends on D11336

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e84c675467af
part 1 - Copy immutableFlags_ word in CopyScript instead of copying each flag separately. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e82a6edf415c
part 2 - Move HideScriptFromDebugger from ImmutableFlags to MutableFlags. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/648aae354898
part 3 - Copy immutableFlags_ word in XDRScript instead of copying each flag separately. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1f940df360da
part 4 - Remove some now-redundant initialization code in JSScript::initFromModuleContext. r=tcampbell

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1505784 part 5 - Assert the HideScriptFromDebugger flag is not set in CopyScript. r?tcampbell

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75880e75e5da
part 5 - Assert the HideScriptFromDebugger flag is not set in CopyScript. r=tcampbell

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e84c675467af
https://hg.mozilla.org/mozilla-central/rev/e82a6edf415c
https://hg.mozilla.org/mozilla-central/rev/648aae354898
https://hg.mozilla.org/mozilla-central/rev/1f940df360da

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/75880e75e5da