Closed Bug 1505784 Opened Last year Closed Last year

Clean up script flags handling in XDRScript/CopyScript


(Core :: JavaScript Engine, enhancement)

Not set



Tracking Status
firefox65 --- fixed


(Reporter: jandem, Assigned: jandem)


(Depends on 1 open bug)



(5 files, 1 obsolete file)

Now that we use flag words for this, we no longer have to copy each flag explicitly in CopyScript and XDRScript.
Note: the old code didn't copy the HasNoScriptRval and SelfHosted flags, because
they are set to the correct values in CreateEmptyScriptForClone. That means it's
fine to copy them as part of the flags word.

The only change in behavior is that we now copy the IsLikelyConstructorWrapper
flag as well.
Attachment #9023635 - Attachment is obsolete: true
Pushed by
part 1 - Copy immutableFlags_ word in CopyScript instead of copying each flag separately. r=tcampbell
part 2 - Move HideScriptFromDebugger from ImmutableFlags to MutableFlags. r=tcampbell
part 3 - Copy immutableFlags_ word in XDRScript instead of copying each flag separately. r=tcampbell
part 4 - Remove some now-redundant initialization code in JSScript::initFromModuleContext. r=tcampbell
Pushed by
part 5 - Assert the HideScriptFromDebugger flag is not set in CopyScript. r=tcampbell
You need to log in before you can comment on or make changes to this bug.