Closed Bug 1505788 Opened 3 years ago Closed 2 years ago

Add new raptor tp6-* test suites to the raptor wiki and the perf-automation git repo

Categories

(Testing :: Raptor, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rwood, Assigned: Bebe)

References

Details

Once the new Raptor tp6-* jobs land (Bug 1503990) the Raptor wiki test list must be updated [1].

Please just copy one of the existing wiki entries for tp6-1 or tp6-2 and add the new page details for the new tp6-* test sets, so the wiki format is consistent.

They include listing all the test pages in each test job, so that developers can find which suite contains which test pages. Thanks!

[1] https://wiki.mozilla.org/Performance_sheriffing/Raptor#Page-Load_Tests
Also note, before moving these new suites to tier 1, along with adding them to the Raptor wiki, the raw html source of the recordings needs to be added to our perf-automation repo at [1].

This is done by playing back each recording, then from Firefox doing a File => Save As and recording the entire page source. Then please create a new github pull request adding the new pages.

This is required so that developers can use the raw page source for debugging, without having to use mitmproxy. Thanks!

[1] https://github.com/rwood-moz/perf-automation/tree/master/pagesets/mitmproxy
Summary: Add new raptor tp6-* test suites to the raptor wiki → Add new raptor tp6-* test suites to the raptor wiki and the perf-automation git repo
:bebe, can you take this bug please and update both the Raptor wiki and the perf-reftest git repo for the new pages you recorded for tp6-3, tp6-4, tp6-5, and tp6-6? Please include links to the updated wiki as well as the github pull request. Thanks!
Flags: needinfo?(fstrugariu)
Assignee: nobody → fstrugariu
Status: NEW → ASSIGNED
(In reply to Florin Strugariu [:Bebe] from comment #3)

Awesome thanks :Bebe. If you could please add the raw html (from the recordings playback in Firefox) to our repo [1] with the other pages then we can close this bug out.

https://github.com/rwood-moz/perf-automation/tree/master/pagesets/mitmproxy/raptor-tp6
:Bebe please add the new pages that you recorded, do our github repo (see Comment 1) thank you
Notes:
1. Reddit page is not loading properly but this is how it saves
2. instagram page refreshes at every 5 sec
3. apple page has no images
(In reply to Florin Strugariu [:Bebe] from comment #6)
> Created pull request:
> https://github.com/rwood-moz/perf-automation/pull/1
> 
> to specified repo:
> https://github.com/rwood-moz/perf-automation/tree/master/pagesets/mitmproxy/
> raptor-tp6
> 
> 
> Should we merge it to: https://github.com/mozilla/perf-automation

Thanks :Bebe. Please don't use specific suite sub-folders, i.e. in your pull request:

 pagesets/mitmproxy/raptor-tp6-3/raptor-IMDb.html

Please just use the same folder structure as the the existing pages in the same repo i.e.:

https://github.com/mozilla/perf-automation/tree/master/pagesets/mitmproxy/raptor-tp6/raptor-tp6-imdb.html (and there will be a raptor-tp6-imdb_files subfolder).

The reason is we may move pages from one suite to another so we just want to have them listed as 'tp6' here. Thanks!
Flags: needinfo?(fstrugariu)
(In reply to Florin Strugariu [:Bebe] from comment #9)
> Updated https://github.com/rwood-moz/perf-automation/pull/1

Great thanks :Bebe! I noticed your pull request was made against my repo (https://github.com/rwood-moz/perf-automation/pull/1) and not the main repo (https://github.com/mozilla/perf-automation/) so I merged it into mine, and created a pull request against the main repo and merged that. In the future please create pull requests against the main repo (https://github.com/mozilla/perf-automation/) thanks!

Merged:

https://github.com/mozilla/perf-automation/commit/600959df55773f0bbca9da373f64f8a7f9e05f27
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.