1505796 - Perfherder Comparison view is slow

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

I'm trying to evaluate a change with Perfherder (which overall, is excellent, and I love it); but moving between pages as you investigate subtests is -incredibly painful-. It feels like there's no caching going on, so we're constantly waiting for the results of large database lookups. 


This is important because performance comparison should be a first class activity if we want to have performance at the top of our mind.

Comment 1

[William Lachance (:wlach)]

I believe the main reason for this is the fact that we're executing (in some cases) hundreds of individual requests for series data within the compare view, often discarding most of what is returned. 

We never wrote a specific REST endpoint on the server side to provide a comparison (something like /perf/compare/?old_revision=1234abcd&new_revision=4567defg). This would have a number of advantages:

1. Should be much faster, because we can query for the information with one REST API call, rather than hundreds. Also, although this API call would by necessity by making a bunch of db queries, we could probably be much more efficient about it.
2. No need to have tons of client code to fetch and aggregate the series data.
3. IME it's easier to test server side code than client side.

I think it would make sense to do this as part of the conversion of the compare view from angular -> react. In addition to being slow, the existing code has been a really unending source of bugs and I think it makes sense to really improve things here if we're going to be making major changes anyway.

Comment 2

[Sarah Clements [:sclements]]

I'll look into it.

Comment 3

[Sarah Clements [:sclements]]

To be more specific (and in response to :wlach's comment) - I'll look into how I can make improvements during the conversion.

Comment 4

[Sarah Clements [:sclements]]

Attachment: GitHub Pull Request

Comment 5

[Sarah Clements [:sclements]]

The bugbot doesn't seem to be picking up my changes, but my pr was merged to master. A new endpoint was created and more improvements will be likely once the compare view is converted to React.