1505800 - [Win] The dropdown from Folder section ( New Bookmark/Edit This Bookmark panels) doesn't collapse when the Choose option is accessed with the down arrow keyboard

Status: ASSIGNED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Anca Soncutean [:Anca], Desktop Release QA]

Attachment: screencast issue .gif

[Affected versions]: 
- 63.0.1 (20181030165643)
- 64.0b7 (20181105164654)
- 65.0a1 (20181107220128)

[Affected platforms]:
- Windows 10 x64
- Windows 7 x86

[Steps to reproduce]:
1. Navigate to any website
2. Click on the “Bookmark this Page” star icon inside the address bar
3. Click on the “˅”, next to the “Other Bookmarks”, inside the “Folder” section
4. With the “down arrow” from the keyboard navigate to the “Choose” option 

[Expected result]:
- The “Folder” dropdown collapses when the “Show all bookmarks folder” panel is displayed.

[Actual result]:
- The “Folder” dropdown remains expanded over the “Show all bookmarks folder” panel.

[Regression range]: 
- This issue occurs somewhere between Fx 39.0a1 and Fx 43.0a1 (“Edit This Bookmark” panel was available only), unfortunately the builds in between are broken, so I couldn't determine a more precisely range. 

[Additional Notes]:
- Mac an Ubuntu platforms are not affected, because when the “Choose” option is in focus,  the “Show all bookmarks folder” panel is not expanded directly, only an [Enter/Click] activates it.

Comment 1

[Marco Bonardo [:mak]]

I'll investigate this one

Comment 2

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Happy to take a patch in nightly; if it seems low risk enough please feel free to request uplift to 65 beta.

Comment 3

[Marco Bonardo [:mak]]

I think this menuitem shouldn't really activate on a simple selection, it's just confusing for the user, especially if the popup is closed (the menulist can also be used that way, tabbing to it). I think we should instead always request a confirmation through a click or Enter, on this specific item. And the menulist popup should always close.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1505800 - The 'Choose Folder' menuitem in the Star panel shouldn't activate on selection. r=Standard8!