1505820 - "You are about to close N tabs" doesn't go away

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[Sergey Vlasov]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Since the recent Nightly update (approximately 65.0a1 (2018-11-01)) I start seeing "You are about to close N tabs" when quitting Firefox.

Previously, the dialog would be displayed only when closing one of the multiple windows, or when session restore wouldn't be enabled. But now the dialog shows up every time. Even though the tabs gets successfully restored on the next Firefox launch.

That's gives me shivers, am I really about to loose all the tabs? Why I'm seeing this otherwise?



Actual results:

Dialog appears no matter what.


Expected results:

Dialog should not appear when exiting Firefox by e.g.:
- closing the last window with "Restore previous session" enabled
- exiting via Ctrl-Q or main menu

Comment 1

[Matthias Versen [:Matti]]

The warning for the keyboard shortcut to close Firefox was added with bug 550559.

This warning dialog should have a checkbox to disable it in the future.
You can see at a screenshot of the german version of this dialog here:
https://i.imgur.com/KBIIrud.png

Is there no checkbox visible in your warning dialog ?

Comment 2

[Vash63]

I'm having issues with this also. I do have the checkbox, but I don't want to check that as I like the old behavior of it warning me when I'm going to close tabs that are not recovered in a session. For example:

1. Open Firefox. Saved session in window #1 opens with a bunch of tabs.
2. Open new window #2 for video streaming or some other content not in a tab.
3. Close window #1, forgetting Window #2 exists on a different workspace/display/minimized/etc - Firefox warns me that I'm about to close multiple tabs, letting me know I'd lose my work.

With the new workflow, there's no difference between closing a window and having your session saved versus closing a window with potential other ones in the background, causing the loss of all tabs in that window.

Comment 3

[Sergey Vlasov]

I also don't want to disable the dialog, since it will not warn me when by accident I close one of the multiple windows.

Comment 4

[Matthias Versen [:Matti]]

>I also don't want to disable the dialog, since it will not warn me when by accident I close one of the multiple windows.
In that case you can reopen the closed window with "alt key/Menu bar/History/Recently closed windows" or just press ctrl+shift+n

Comment 5

[:Gijs (he/him)]

(In reply to Matthias Versen [:Matti] from comment #4)
> >I also don't want to disable the dialog, since it will not warn me when by accident I close one of the multiple windows.
> In that case you can reopen the closed window with "alt key/Menu
> bar/History/Recently closed windows" or just press ctrl+shift+n

Yeah, this was a deliberate change in bug 550559, so I'm going to close this bug out.

Clearly, we can't make everybody happy all of the time, but the previous behavior was really non-obvious to people, and led to actual lost work for people who fat-fingered the cmd-q or ctrl-q keyboard shortcuts but didn't want to close the browser, and there was no way to force a dialog to come up in that case. If you're worried about dataloss, I don't really understand why you'd want the dialog some but not all of the time, as both your entire session and tabs/windows are restorable using the same menu.

In any case, the behavior you want can be accomplished by setting the `browser.warnOnQuit` about:config pref to `false`, while keeping the `browser.tabs.warnOnClose` pref set to `true`.

Comment 6

[Sergey Vlasov]

> In any case, the behavior you want can be accomplished by setting the `browser.warnOnQuit` about:config pref to `false`, while keeping the `browser.tabs.warnOnClose` pref set to `true`.

I can confirm, that this brings the old behavior back.