Closed Bug 1505835 Opened Last year Closed 11 months ago

Tiled blob images broke capture infrastructure

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: bholley, Unassigned)

References

(Blocks 1 open bug)

Details

I just tried to capture with ctrl+shift+3. This hit the following assertion, which seems to assert that blobs are not tiled (which changed recently):

https://searchfox.org/mozilla-central/rev/17f55aee76b7c4610a974cffd3453454e0c8de7b/gfx/webrender/src/resource_cache.rs#1905

Output as follows:

--DOMWINDOW == 25 (0x12c9b5600) [pid = 46450] [serial = 6] [outer = 0x0] [url = ]
--------------------------
 Capturing WR state to: "wr-capture"
--------------------------
thread 'WRRenderBackend#1' panicked at 'assertion failed: `(left == right)`
  left: `Some(256)`,
 right: `None`', gfx/webrender/src/resource_cache.rs:1905:21
stack backtrace:
   0:        0x111a2ca4f - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::hd303b0cd45bccf60
   1:        0x111a071fd - std::sys_common::backtrace::print::hf2fe31942821bdcb
   2:        0x111a315e3 - std::panicking::default_hook::{{closure}}::h748cb38cc840cba6
   3:        0x111a3136c - std::panicking::default_hook::h81d2ef89c2ad110e
   4:        0x111a31d17 - std::panicking::rust_panic_with_hook::h67318ff56366ae20
   5:        0x111a3187c - std::panicking::continue_panic_fmt::h2d9dbf1e069d262d
   6:        0x111a317d0 - std::panicking::begin_panic_fmt::he0631dadb89432ed
   7:        0x110f62f53 - webrender::resource_cache::ResourceCache::save_capture::h10eb73eaf55f57ab
   8:        0x110e01d1b - webrender::render_backend::RenderBackend::save_capture::hb4047c9e71bf6e95
   9:        0x110dffe8b - webrender::render_backend::RenderBackend::process_api_msg::haf724ee7f82d60ff
  10:        0x110dfea96 - webrender::render_backend::RenderBackend::run::h0a900475b3417419
Redirecting call to abort() to mozalloc_abort

Hit MOZ_CRASH() at /files/mozilla/mc/q/memory/mozalloc/mozalloc_abort.cpp:35
Priority: -- → P3
I believe this is very important to get us productive. It's not a blocker for releasing anything, but it should be fixed ASAP.
Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED
This PR should fix the panics, but it doesn't yet bring full support for tiled images. Stuff like reddit.com can now be captured and replayed safely, so this is no longer a high priority, de-assigning (for now).
Assignee: dmalyshau → nobody
Status: ASSIGNED → NEW
This bug as filed is fixed. We can get another bug on file for full tiled image support if it becomes a problem.
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.