Closed Bug 1505847 Opened 6 years ago Closed 6 years ago

Find bar buttons are rectangular, border-radius fails to apply

Categories

(Firefox :: Theme, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

This is weird... we appear to be setting border-radius to the right value but it doesn't seem to do anything. Maybe border-radius generally doesn't work on <xul:label>?
Priority: -- → P3
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/352ca0c86704
Clean up .findbar-button styling. r=jaws
https://hg.mozilla.org/mozilla-central/rev/352ca0c86704
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
This change removed the hover/checked/active states from the findbar buttons on macOS.

There's this rule that needed to be taken care of: https://searchfox.org/mozilla-central/source/browser/themes/osx/browser.css#211-216
Flags: needinfo?(dao+bmo)
Please file new bugs for regressions rather than leaving a comment.
Flags: needinfo?(dao+bmo)
Depends on: 1506869
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: