Closed Bug 1505867 Opened 11 months ago Closed 11 months ago

Reduce log spew from hpack code

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: u408661, Assigned: u408661)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Our logs are noisy enough already, and combined with the default of "sync" in the log modules on about:networking, that can change timing of some race bugs (see https://bugzilla.mozilla.org/show_bug.cgi?id=1409570#c28).

One big source of noise (when http/2 is involved) is the dump of the hpack table we do after Every. Single. Table. Operation. Not only is this a lot of data that isn't necessary (it was helpful during hpack standardization, to ensure we were behaving properly, but not so much any more), it makes looking through logs manually a pain (especially when you're searching for a header or URL).

Understanding, however, that people are in fact still writing their own http/2 stacks (see https://bugzilla.mozilla.org/show_bug.cgi?id=1500743) and that these new stacks may, in fact, be buggy, it could be helpful to keep this code in the tree in order to assist with debugging interactions with buggy servers.

So, instead of removing the table dumps entirely, let's make them preffable, off by default.
Whiteboard: [necko-triaged]
Now that h2 is pretty well stable, and we're fairly confident in our hpack table implementation, it's worth hiding this logging without some extra hoops, as it's just a lot of noise in logs.
Pushed by hurley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3d642b62488
Add pref for hpack table dumps. r=bagder
https://hg.mozilla.org/mozilla-central/rev/d3d642b62488
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.