1505897 - Focus+GV crashes loading booking.com

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Chris Peterson [:cpeterson]]

No-Jun reported this bug on GitHub:

https://github.com/mozilla-mobile/focus-android/issues/3859

STR:
1. Load https://www.booking.com/

RESULT:
Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 12585 (Web Content)
DEBUG : Cause: null pointer dereference

Looks like some linker issue:

#00 pc 0005df7c /system/bin/linker (__dl_syscall+32)
#01 pc 000190bf /system/bin/linker (__dl__ZL13resend_signalP7siginfob+54)

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1505897 - Initialize GeckoSystemStateListener in child process r=agi

Comment 3

[Chris Peterson [:cpeterson]]

James, it looks like Autoland failed to land your GeckoSystemStateListener fix. We should uplift this fix to GV 64 Beta for the Focus 8.0 Beta rollout starting this week.

---

Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp5tm4Oa\npatching file mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java\nHunk #1 FAILED at 276\n1 out of 1 hunks FAILED -- saving rejects to file mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java.rej\nabort: patch failed to apply', '')

https://lando.services.mozilla.com/D11517/

Comment 4

[Chris Peterson [:cpeterson]]

Some GV 64 crash reports from Focus 8.0 Beta are starting to roll in and this GeckoSystemStateListener crash is one of them:

https://crash-stats.mozilla.com/search/?product=Focus&version=64.0b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef83f24a68ac
Initialize GeckoSystemStateListener in child process r=agi

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest crashes on test_mq_prefers_reduced_motion_dynamic.html. 

Backout link: https://hg.mozilla.org/integration/autoland/rev/8f260179cc9fe83cc36b185ed8a03c7a1848ba1a
Push link: https://hg.mozilla.org/integration/autoland/rev/ef83f24a68ac59080fda9efaff9dadc276ef6f73
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=212075341&repo=autoland&lineNumber=1407

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/766dc4a5e8f0
Initialize GeckoSystemStateListener in child process r=agi

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9024077 [details]
Bug 1505897 - Initialize GeckoSystemStateListener in child process r=agi

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A

User impact if declined: Crashes. Lots of crashes.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Navigate to booking.com with the example app

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): 

String changes made/needed: None

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/766dc4a5e8f0

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9024077 [details]
Bug 1505897 - Initialize GeckoSystemStateListener in child process r=agi

crash fix for focus, approved for 64.0b11

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/28b294890d1c

Comment 12

[Oana Horvath [:ohorvath]]

Verified the fix on Focus debug build - not reproducing anymore.
This was not merged on Focus Nightly yet. For future reference: where would it be best for the Fennec team to check these GV bugs when they appear in the Beta uplifts list?

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Oana Horvath from comment #12)
> Verified the fix on Focus debug build - not reproducing anymore.
> This was not merged on Focus Nightly yet. For future reference: where would
> it be best for the Fennec team to check these GV bugs when they appear in
> the Beta uplifts list?

For GV bugs that affect Fennec, you may be able to reproduce them in a Custom Tab. This bug is e10s only, though, so it doesn't affect Fennec.

Comment 14

[Oana Horvath [:ohorvath]]

(In reply to Oana Horvath from comment #12)
> Verified the fix on Focus debug build - not reproducing anymore.
> This was not merged on Focus Nightly yet. For future reference: where would
> it be best for the Fennec team to check these GV bugs when they appear in
> the Beta uplifts list?

Actually, sorry about that. I was testing the Focus webView build. Still reproducing on the Focus GeckoView version.
Thank you for your reply!

Comment 15

[Chris Peterson [:cpeterson]]

status-geckoview64=fixed