Closed Bug 1505897 Opened 10 months ago Closed 9 months ago

Focus+GV crashes loading booking.com

Categories

(GeckoView :: General, defect, P1)

Unspecified
Android
defect

Tracking

(geckoview64 fixed, firefox63 unaffected, firefox64 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
geckoview64 --- fixed
firefox63 --- unaffected
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: cpeterson, Assigned: snorp)

References

()

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

No-Jun reported this bug on GitHub:

https://github.com/mozilla-mobile/focus-android/issues/3859

STR:
1. Load https://www.booking.com/

RESULT:
Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 12585 (Web Content)
DEBUG : Cause: null pointer dereference

Looks like some linker issue:

#00 pc 0005df7c /system/bin/linker (__dl_syscall+32)
#01 pc 000190bf /system/bin/linker (__dl__ZL13resend_signalP7siginfob+54)
Assignee: nobody → snorp
Duplicate of this bug: 1503075
James, it looks like Autoland failed to land your GeckoSystemStateListener fix. We should uplift this fix to GV 64 Beta for the Focus 8.0 Beta rollout starting this week.

---

Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp5tm4Oa\npatching file mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java\nHunk #1 FAILED at 276\n1 out of 1 hunks FAILED -- saving rejects to file mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java.rej\nabort: patch failed to apply', '')

https://lando.services.mozilla.com/D11517/
Flags: needinfo?(snorp)
Some GV 64 crash reports from Focus 8.0 Beta are starting to roll in and this GeckoSystemStateListener crash is one of them:

https://crash-stats.mozilla.com/search/?product=Focus&version=64.0b
Crash Signature: [@ java.lang.NullPointerException: at org.mozilla.gecko.GeckoSystemStateListener.prefersReducedMotion(GeckoSystemStateListener.java)]
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef83f24a68ac
Initialize GeckoSystemStateListener in child process r=agi
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/766dc4a5e8f0
Initialize GeckoSystemStateListener in child process r=agi
Comment on attachment 9024077 [details]
Bug 1505897 - Initialize GeckoSystemStateListener in child process r=agi

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A

User impact if declined: Crashes. Lots of crashes.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Navigate to booking.com with the example app

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): 

String changes made/needed: None
Flags: needinfo?(snorp)
Attachment #9024077 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/766dc4a5e8f0
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment on attachment 9024077 [details]
Bug 1505897 - Initialize GeckoSystemStateListener in child process r=agi

crash fix for focus, approved for 64.0b11
Attachment #9024077 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified the fix on Focus debug build - not reproducing anymore.
This was not merged on Focus Nightly yet. For future reference: where would it be best for the Fennec team to check these GV bugs when they appear in the Beta uplifts list?
(In reply to Oana Horvath from comment #12)
> Verified the fix on Focus debug build - not reproducing anymore.
> This was not merged on Focus Nightly yet. For future reference: where would
> it be best for the Fennec team to check these GV bugs when they appear in
> the Beta uplifts list?

For GV bugs that affect Fennec, you may be able to reproduce them in a Custom Tab. This bug is e10s only, though, so it doesn't affect Fennec.
(In reply to Oana Horvath from comment #12)
> Verified the fix on Focus debug build - not reproducing anymore.
> This was not merged on Focus Nightly yet. For future reference: where would
> it be best for the Fennec team to check these GV bugs when they appear in
> the Beta uplifts list?

Actually, sorry about that. I was testing the Focus webView build. Still reproducing on the Focus GeckoView version.
Thank you for your reply!
status-geckoview64=fixed
Depends on: 1513242
Depends on: 1512037
No longer depends on: 1512037
Product: Firefox for Android → GeckoView
Keywords: crash
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.