Closed Bug 1505897 Opened 2 years ago Closed 2 years ago
Focus+GV crashes loading booking
47 bytes, text/x-phabricator-request
|Details | Review|
No-Jun reported this bug on GitHub: https://github.com/mozilla-mobile/focus-android/issues/3859 STR: 1. Load https://www.booking.com/ RESULT: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 12585 (Web Content) DEBUG : Cause: null pointer dereference Looks like some linker issue: #00 pc 0005df7c /system/bin/linker (__dl_syscall+32) #01 pc 000190bf /system/bin/linker (__dl__ZL13resend_signalP7siginfob+54)
2 years ago
Assignee: nobody → snorp
2 years ago
Duplicate of this bug: 1503075
James, it looks like Autoland failed to land your GeckoSystemStateListener fix. We should uplift this fix to GV 64 Beta for the Focus 8.0 Beta rollout starting this week. --- Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp5tm4Oa\npatching file mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java\nHunk #1 FAILED at 276\n1 out of 1 hunks FAILED -- saving rejects to file mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java.rej\nabort: patch failed to apply', '') https://lando.services.mozilla.com/D11517/
Some GV 64 crash reports from Focus 8.0 Beta are starting to roll in and this GeckoSystemStateListener crash is one of them: https://crash-stats.mozilla.com/search/?product=Focus&version=64.0b
Crash Signature: [@ java.lang.NullPointerException: at org.mozilla.gecko.GeckoSystemStateListener.prefersReducedMotion(GeckoSystemStateListener.java)]
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ef83f24a68ac Initialize GeckoSystemStateListener in child process r=agi
Backed out for mochitest crashes on test_mq_prefers_reduced_motion_dynamic.html. Backout link: https://hg.mozilla.org/integration/autoland/rev/8f260179cc9fe83cc36b185ed8a03c7a1848ba1a Push link: https://hg.mozilla.org/integration/autoland/rev/ef83f24a68ac59080fda9efaff9dadc276ef6f73 Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=212075341&repo=autoland&lineNumber=1407
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/766dc4a5e8f0 Initialize GeckoSystemStateListener in child process r=agi
Comment on attachment 9024077 [details] Bug 1505897 - Initialize GeckoSystemStateListener in child process r=agi [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: N/A User impact if declined: Crashes. Lots of crashes. Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: No Needs manual test from QE?: Yes If yes, steps to reproduce: Navigate to booking.com with the example app List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): String changes made/needed: None
Attachment #9024077 - Flags: approval-mozilla-beta?
Comment on attachment 9024077 [details] Bug 1505897 - Initialize GeckoSystemStateListener in child process r=agi crash fix for focus, approved for 64.0b11
Attachment #9024077 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified the fix on Focus debug build - not reproducing anymore. This was not merged on Focus Nightly yet. For future reference: where would it be best for the Fennec team to check these GV bugs when they appear in the Beta uplifts list?
(In reply to Oana Horvath from comment #12) > Verified the fix on Focus debug build - not reproducing anymore. > This was not merged on Focus Nightly yet. For future reference: where would > it be best for the Fennec team to check these GV bugs when they appear in > the Beta uplifts list? For GV bugs that affect Fennec, you may be able to reproduce them in a Custom Tab. This bug is e10s only, though, so it doesn't affect Fennec.
(In reply to Oana Horvath from comment #12) > Verified the fix on Focus debug build - not reproducing anymore. > This was not merged on Focus Nightly yet. For future reference: where would > it be best for the Fennec team to check these GV bugs when they appear in > the Beta uplifts list? Actually, sorry about that. I was testing the Focus webView build. Still reproducing on the Focus GeckoView version. Thank you for your reply!
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.