Bug 1505906 - Update some CSS to recent changes in the DOM structure to fix dragging tabs onto toolbar items. r?dao
47 bytes, text/x-phabricator-request
|Details | Review|
[Tracking Requested - why for this release]: Bug 1356920 broke the dragging of tabs into the bookmarks menu as a way to bookmark tabs. 9:57.61 INFO: Last good revision: 1ab00b6e99fd65b651381c235f1ae95ed746e57a 9:57.61 INFO: First bad revision: e354a018b703c453e8afcda1f44f1d51456536f5 9:57.61 INFO: Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1ab00b6e99fd65b651381c235f1ae95ed746e57a&tochange=e354a018b703c453e8afcda1f44f1d51456536f5 STR: 1. make sure that you have the bookmarks menu in the toolbar 2. drag a tab into the bookmarks menu Expected: The bookmarks menu opens and you can place the tab in the bookmarks menu or a subfolder. Actual: The bookmarks menu does not open.
Well, that's a fun feature I didn't know we had. And I guess we have no test coverage for. :/
Assignee: nobody → mconley
Component: General → Bookmarks & History
Hey dao, I responded to your review feedback. I'm reasonably certain I have the right CSS selectors here. Or am I missing something?
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/f1b7aa784d8c Update some CSS to recent changes in the DOM structure to fix dragging tabs onto toolbar items. r=dao
I can reproduce this issue in Nightly 65.0a1 (2018-11-08) (64-bit) on Linux x86_64 I can verify that this is fixed in latest Nightly Build ID 20181129095546 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0
QA Whiteboard: [bugday-20181128]
Hello, I reproduced this issue using Fx 65.0a1, build ID: 20181108220756, on Ubuntu 18.04 x64. I can confirm this issue is verified as fixed using Fx 65.0b5, build ID: 20181217180946, on Windows 10 x32, macOS X 10.13 and Ubuntu 18.04.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.