Support some calls in the middleman made by the socket transport service thread

RESOLVED FIXED in Firefox 65

Status

()

RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks: 1 bug)

unspecified
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
In some cases after diverging from the recording the socket transport service thread can make some calls to create new pipes and change attributes of their file descriptors.  Currently we crash on these (on the main thread we would have a repaint failure and restore the last checkpoint, but we don't support doing this off the main thread).  The attached patch adds handling for pipe() and fcntl() to take care of this.
(Assignee)

Comment 1

4 months ago
Posted patch patchSplinter Review
Attachment #9023799 - Flags: review?(lsmyth)
Attachment #9023799 - Flags: review?(lsmyth) → review+

Comment 2

4 months ago
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8fc37bd01ba
Support some calls in the middleman made by the socket transport service thread, r=lsmyth.

Comment 3

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8fc37bd01ba
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.