Closed
Bug 1505959
Opened 6 years ago
Closed 6 years ago
Support some calls in the middleman made by the socket transport service thread
Categories
(Core Graveyard :: Web Replay, enhancement)
Core Graveyard
Web Replay
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
2.45 KB,
patch
|
loganfsmyth
:
review+
|
Details | Diff | Splinter Review |
In some cases after diverging from the recording the socket transport service thread can make some calls to create new pipes and change attributes of their file descriptors. Currently we crash on these (on the main thread we would have a repaint failure and restore the last checkpoint, but we don't support doing this off the main thread). The attached patch adds handling for pipe() and fcntl() to take care of this.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9023799 -
Flags: review?(lsmyth)
Updated•6 years ago
|
Attachment #9023799 -
Flags: review?(lsmyth) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a8fc37bd01ba Support some calls in the middleman made by the socket transport service thread, r=lsmyth.
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a8fc37bd01ba
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•