Closed Bug 1506029 Opened 2 years ago Closed 2 years ago

Fix the way tracking of messages that have a suspiciously large number of referents

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

Details

Attachments

(1 file)

In MessageManagerReporter::CountReferents,


    // Keep track of messages that have a suspiciously large
    // number of referents (symptom of leak).
    if (currentCount == MessageManagerReporter::kSuspectReferentCount) {
      aReferentCount->mSuspectMessages.AppendElement(key);
    }

currentCount should be larger than MessageManagerReporter::kSuspectReferentCount

Otherwise, it won't reveal the correct message listener leakage.
Assignee: nobody → shawnjohnjr
Priority: -- → P2
I don't have a permission to land this patch using lado since I only have level 1 permission.
Can someone help me to land this patch?
Let's try with "checkin-needed" and see what happens... I'm not sure how to do this with Lando/Phabricator, so will be a new experience for all us :)
Keywords: checkin-needed
(In reply to Marcos Caceres [:marcosc] (triage duty) from comment #3)
> Let's try with "checkin-needed" and see what happens... I'm not sure how to
> do this with Lando/Phabricator, so will be a new experience for all us :)

I just figured out how to use lando but I was blocked due to no level-3 permission.
But it's still good to be a contributor again :-)
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c980c224a3c
Fix the way tracking of messages that have a large number of referents. r=njn
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1c980c224a3c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.