1506029 - Fix the way tracking of messages that have a suspiciously large number of referents

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

In MessageManagerReporter::CountReferents,


    // Keep track of messages that have a suspiciously large
    // number of referents (symptom of leak).
    if (currentCount == MessageManagerReporter::kSuspectReferentCount) {
      aReferentCount->mSuspectMessages.AppendElement(key);
    }

currentCount should be larger than MessageManagerReporter::kSuspectReferentCount

Otherwise, it won't reveal the correct message listener leakage.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1506029 - Fix the way tracking of messages that have a large number of referents. r?njn

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I don't have a permission to land this patch using lado since I only have level 1 permission.
Can someone help me to land this patch?

Comment 3

[Marcos Caceres [:marcosc]]

Let's try with "checkin-needed" and see what happens... I'm not sure how to do this with Lando/Phabricator, so will be a new experience for all us :)

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Marcos Caceres [:marcosc] (triage duty) from comment #3)
> Let's try with "checkin-needed" and see what happens... I'm not sure how to
> do this with Lando/Phabricator, so will be a new experience for all us :)

I just figured out how to use lando but I was blocked due to no level-3 permission.
But it's still good to be a contributor again :-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c980c224a3c
Fix the way tracking of messages that have a large number of referents. r=njn

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1c980c224a3c