Code cleanup: Convert more static functions to lambdas in the markup map

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P2
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

Trunk
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Right now, we have a wild mix of lambdas in accessible/base/markupmap.h, and a set of static functions in accessible/base/nsAccessibilityService.cpp.

To make this more maintainable for future additions, I am going to convert those static functions that make sense to lambdas in the markup map.
All static functions from nsAccessibilityService that were either only called once from the markup map, or are simple one-liners that were only called up to three times, were converted to lambdas in the markup map.

the static function that creates HyperTextAccessibleWrap has remained untouched because it is called a lot from the markup map, even though its implementation is actually just a one-liner.

The other untouched static function is the templated one for html:dt or html:dd.

Comment 2

7 months ago
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4a258084934
Code cleanup: Convert more static functions to lambdas in the markup map, r=Jamie

Comment 3

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d4a258084934
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.