Closed
Bug 1506041
Opened 7 years ago
Closed 7 years ago
Code cleanup: Convert more static functions to lambdas in the markup map
Categories
(Core :: Disability Access APIs, enhancement, P2)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: MarcoZ, Assigned: MarcoZ)
Details
Attachments
(1 file)
Right now, we have a wild mix of lambdas in accessible/base/markupmap.h, and a set of static functions in accessible/base/nsAccessibilityService.cpp.
To make this more maintainable for future additions, I am going to convert those static functions that make sense to lambdas in the markup map.
| Assignee | ||
Comment 1•7 years ago
|
||
All static functions from nsAccessibilityService that were either only called once from the markup map, or are simple one-liners that were only called up to three times, were converted to lambdas in the markup map.
the static function that creates HyperTextAccessibleWrap has remained untouched because it is called a lot from the markup map, even though its implementation is actually just a one-liner.
The other untouched static function is the templated one for html:dt or html:dd.
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4a258084934
Code cleanup: Convert more static functions to lambdas in the markup map, r=Jamie
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•