Wait for GPU after posting NotifyDidRender

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

On current gecko, NotifyDidRender is posted after gpu tasks wait of RenderCompositorANGLE::WaitForPreviousPresentQuery().

https://dxr.mozilla.org/mozilla-central/source/gfx/webrender_bindings/RenderThread.cpp#403

But the WaitForPreviousPresentQuery() is not necessary for the NotifyDidRender. The NotifyDidRender is called for current webrender rendering, that is posted by "mSwapChain->Present(0, 0)".

The WaitForPreviousPresentQuery() does wait for gpu tasks of 2 previous webrender rendering. It is necessary for Textures recycling of AsyncImagePipelineManager and for avoiding GPU queue is filled with too much tasks.
Assignee: nobody → sotaro.ikeda.g
Attachment #9023925 - Flags: review?(matt.woodrow)
Attachment #9023925 - Flags: review?(matt.woodrow) → review+

Comment 3

6 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95ba19cf3ce2
Wait for GPU after posting NotifyDidRender r=mattwoodrow

Comment 4

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/95ba19cf3ce2
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.