1506101 - WebExtension icon is block in toolbar after removed the add-ons from about:addons

Status: NEW

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA]

Attachment: Icon-block-in-toolbar.zip

[Affected versions]:
 Fx 65.0a1
 Fx 64.0b8
 Fx 63.0.1
 Fx 60.0.3esr
 
[Affected platforms]:
 Windows 10 x64
 macOS 10.14
 Ubuntu 16.04 x86

[Steps to reproduce]:
 1. Launch Firefox.
 2. Install some add-ons that put an icon in the toolbar ex: 
    https://addons.mozilla.org/en-US/firefox/addon/ghostery/?src=cb-dl-users
    https://addons.mozilla.org/en-US/firefox/addon/screenshot-capture-annotate/?src=cb-dl-users
    https://addons.mozilla.org/en-US/firefox/addon/evernote-web-clipper/?src=cb-dl-users

 3. Go to about:addons and disable/enable, remove/undo repeatedly the add-ons. 

[Expected result]:
 The add-on enabled/disabled correctly, the add-on removed from Extensions list and if it had an icon in toolbar that was removed too.

[Actual result]:
 The add-on removed from Extensions list and the icon not removed from toolbar.
 (see: Icon-blocked-in-toolbar.png and Icon-block-in-toolbar.png)

[Note]:
 Sometime after more click on disable/enable button the icon not appear anymore in the toolbar, this happens in build 60.3.0esr. (see: Icon-not-in-toolbar.png)

[Regression range]:
  Last GOOD: 20170710030203 (56.0a1)
  First BAD: 20170711030203
  Pushlog:https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=06c1a0dc0fd8719ffa2d9aa2de75f32de5657102&tochange=0e41d07a703f19224f60b01577b2cbb5708046c9

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Timea,
do you mind to check for errors logged in the "Browser Console" right after you triggered the issue?

Comment 2

[Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA]

Attachment: browserconsoleerror.png

These are the errors form "Browser console", hope it's usefull for you, I attached a screenshot too:

[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMWindowUtils.addSheet]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/ExtensionCommon.jsm :: runSafeSyncWithoutClone :: line 65"  data: no]
runSafeSyncWithoutClone
resource://gre/modules/ExtensionCommon.jsm:65:12
inject/cssPromise<
resource://gre/modules/ExtensionContent.jsm:454:13

[Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIWebNavigation.loadURIWithOptions]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource://gre/actors/WebNavigationChild.jsm :: loadURI/< :: line 114"  data: no]