Closed
Bug 1506179
Opened 6 years ago
Closed 6 years ago
Rename webgl::AttribBaseType::Bool
Categories
(Core :: Graphics: CanvasWebGL, enhancement, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)
Details
Attachments
(1 file)
X11.h defines a macro named "Bool". I keep accidentally causing X11.h to be included in places we use webgl::AttribBaseType::Bool, which leads to painful compilation errors. Simply renaming Bool -> Boolean would resolve this pain.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9024021 -
Attachment description: Bug 1506179 - rename webgl::AttribBaseType::Bool to Boolean; r?emilio → Bug 1506179 - rename webgl::AttribBaseType::Bool to Boolean; r?jgilbert
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99d830166ae2 rename webgl::AttribBaseType::Bool to Boolean; r=jgilbert
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/99d830166ae2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•