Closed Bug 1506179 Opened Last year Closed Last year

Rename webgl::AttribBaseType::Bool

Categories

(Core :: Canvas: WebGL, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

Details

Attachments

(1 file)

X11.h defines a macro named "Bool". I keep accidentally causing X11.h to be included in places we use webgl::AttribBaseType::Bool, which leads to painful compilation errors. Simply renaming Bool -> Boolean would resolve this pain.
Attachment #9024021 - Attachment description: Bug 1506179 - rename webgl::AttribBaseType::Bool to Boolean; r?emilio → Bug 1506179 - rename webgl::AttribBaseType::Bool to Boolean; r?jgilbert
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99d830166ae2
rename webgl::AttribBaseType::Bool to Boolean; r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/99d830166ae2
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.