Closed
Bug 1506180
Opened 6 years ago
Closed 6 years ago
clean up windows mozconfigs a little bit
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(2 files)
4.48 KB,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
3.19 KB,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
We should really do more here by moving all of the logic in the
mozconfig.vs2017 files into moz.configure, but this is a start.
![]() |
Assignee | |
Comment 1•6 years ago
|
||
This change makes the lines a little longer, but ideally makes changes
easier and nicer to read.
Attachment #9024023 -
Flags: review?(ryanvm)
![]() |
Assignee | |
Comment 2•6 years ago
|
||
We no longer support MSVC 2015.
Attachment #9024024 -
Flags: review?(ryanvm)
Comment 3•6 years ago
|
||
Comment on attachment 9024023 [details] [diff] [review]
part 1 - factor out a win_sdk_version variable
Review of attachment 9024023 [details] [diff] [review]:
-----------------------------------------------------------------
<3 thanks for doing this. Will make future SDK updates much less of a pain.
Attachment #9024023 -
Flags: review?(ryanvm) → review+
Updated•6 years ago
|
Attachment #9024024 -
Flags: review?(ryanvm) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0698821c5ebd
part 1 - factor out a win_sdk_version variable; r=RyanVM
https://hg.mozilla.org/integration/mozilla-inbound/rev/3787e34b3595
part 2 - delete VS2015 mozconfigs; r=RyanVM
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0698821c5ebd
https://hg.mozilla.org/mozilla-central/rev/3787e34b3595
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•