Closed Bug 1506180 Opened 6 years ago Closed 6 years ago

clean up windows mozconfigs a little bit

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

We should really do more here by moving all of the logic in the mozconfig.vs2017 files into moz.configure, but this is a start.
This change makes the lines a little longer, but ideally makes changes easier and nicer to read.
Attachment #9024023 - Flags: review?(ryanvm)
We no longer support MSVC 2015.
Attachment #9024024 - Flags: review?(ryanvm)
Comment on attachment 9024023 [details] [diff] [review] part 1 - factor out a win_sdk_version variable Review of attachment 9024023 [details] [diff] [review]: ----------------------------------------------------------------- <3 thanks for doing this. Will make future SDK updates much less of a pain.
Attachment #9024023 - Flags: review?(ryanvm) → review+
Attachment #9024024 - Flags: review?(ryanvm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0698821c5ebd part 1 - factor out a win_sdk_version variable; r=RyanVM https://hg.mozilla.org/integration/mozilla-inbound/rev/3787e34b3595 part 2 - delete VS2015 mozconfigs; r=RyanVM
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: