Closed
Bug 1506200
Opened 6 years ago
Closed 6 years ago
Remove ReadableStream EmbeddingFlags
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The idea was to provide some distinguishing bits in case an embedding has many types of external stream. But really this is a waste of memory. It's currently unused, and in practice the underlyingSource pointer will be a pointer to some object that has a C++ vptr and can simply be asked for its type. Right?
|
||
Comment 1•6 years ago
|
||
Yes I agree with you. We can get rid of it.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
r?baku for the bits in dom/fetch, r?jwalden for the rest.
|
|
Assignee | |
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=35676e239e8f0056159208053ebce8cc41de7f78
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b14418449896 Remove ReadableStream EmbeddingFlags. r=baku,jwalden
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b14418449896
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•