1506214 - Wrong text color in active identity popup button

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Tim Nguyen :ntim]

Attachment: Screen Shot 2018-11-09 at 8.07.31 PM.png

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1506214 - Fix identity popup footer button color. r?bgrins

Comment 2

[Tim Nguyen :ntim]

Note that the bookmarks panel footer buttons are also affected by this bug.

Comment 3

[Tim Nguyen :ntim]

Attachment: Screen Shot 2018-11-10 at 2.13.16 PM.png

Other permission prompts also have the same bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6684f68ff1d2
Fix identity popup footer button color. r=bgrins

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6684f68ff1d2

Comment 6

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can't reproduced this issue using Firefox 65.0a1 (2018.11.09) neither on Win 10 x64, Ubuntu 18.04 and neither on Mac OS X 10.13 and Mac OS X 10.10.
I do some tests using Firefox 65.0b12 on Win 10 x64, Mac OS X 10.13 and Ubuntu 18.04 x64 the issue no more reproduced.
Tim, could you help me with more information to reproduced this issue? I see you use Mac OS X and please tell me if you change the theme or use high contrast?

Comment 7

[Tim Nguyen :ntim]

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #6)

I can't reproduced this issue using Firefox 65.0a1 (2018.11.09) neither on Win 10 x64, Ubuntu 18.04 and neither on Mac OS X 10.13 and Mac OS X 10.10.
I do some tests using Firefox 65.0b12 on Win 10 x64, Mac OS X 10.13 and Ubuntu 18.04 x64 the issue no more reproduced.
Tim, could you help me with more information to reproduced this issue? I see you use Mac OS X and please tell me if you change the theme or use high contrast?

Yes, this is macOS only, and it only happens when you keep your mouse pressed on the button. This is the default theme.

Comment 8

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I reproduced this issue on Mac OS X 10.13 at the bookmarks panel footer buttons using Firefox nightly build from 2018.12.19.
I can confirm this issue is fixed, I verified on Firefox 65.0b12 and on 65.0 on Mac OS X 10.13.