1506233 - On Windows 10 with accent color applied to the titlebar, paint the background of the inactive tabs with the theme color

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

Since Bug 1505318 and accent colour enabled on titlebars, only the active tab has the theme background colour. We can do the same as Windows 7 has and also add the theme background colour to the inactive tabs.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1506233-accent-tabs.patch

This makes it better when multiple tabs are opened.

You need to test this with drawInTitlebar and accent colour applied to the titlebars.

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks, we've discussed this in bug 1505318 comment #4.

Doesn't work for the default theme :-( - And on the dark theme there is a glitch that the tab separators are not drawn correctly. Try four tabs and check the and check the separators between 1st and 2nd and 2nd and 3rd. Funny effects depending on how may tabs you have and what is hovered.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1506233-accent-tabs.patch v2

This should fix it.

Comment 4

[Jorg K (CEST = GMT+2)]

Yes, the separators are good now, but it still doesn't work for the default theme.

Comment 5

[Richard Marti (:Paenglab)]

On Windows 7 this is also only working with the Dark and Light themes. Like this we are consistent.

Comment 6

[Jorg K (CEST = GMT+2)]

:-( - The whole idea was to get rid of toooooo much accent colour.

Comment 7

[Richard Marti (:Paenglab)]

On the Dark/Light themes which removed the background colour in bug 1505318. Default was always like this.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9024110 [details] [diff] [review]
1506233-accent-tabs.patch v2

I'm not 100% convinced, but you're the theme guy ;-)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b1d1536882ec
On Windows 10 with accent color applied to the titlebar, paint the background of the inactive tabs with the theme color. r=jorgk