On Windows 10 with accent color applied to the titlebar, paint the background of the inactive tabs with the theme color

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 65.0
All
Windows 10

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Since Bug 1505318 and accent colour enabled on titlebars, only the active tab has the theme background colour. We can do the same as Windows 7 has and also add the theme background colour to the inactive tabs.
Posted patch 1506233-accent-tabs.patch (obsolete) — Splinter Review
This makes it better when multiple tabs are opened.

You need to test this with drawInTitlebar and accent colour applied to the titlebars.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9024076 - Flags: review?(jorgk)
Thanks, we've discussed this in bug 1505318 comment #4.

Doesn't work for the default theme :-( - And on the dark theme there is a glitch that the tab separators are not drawn correctly. Try four tabs and check the and check the separators between 1st and 2nd and 2nd and 3rd. Funny effects depending on how may tabs you have and what is hovered.
This should fix it.
Attachment #9024076 - Attachment is obsolete: true
Attachment #9024076 - Flags: review?(jorgk)
Attachment #9024110 - Flags: review?(jorgk)
Yes, the separators are good now, but it still doesn't work for the default theme.
On Windows 7 this is also only working with the Dark and Light themes. Like this we are consistent.
:-( - The whole idea was to get rid of toooooo much accent colour.
On the Dark/Light themes which removed the background colour in bug 1505318. Default was always like this.
Comment on attachment 9024110 [details] [diff] [review]
1506233-accent-tabs.patch v2

I'm not 100% convinced, but you're the theme guy ;-)
Attachment #9024110 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b1d1536882ec
On Windows 10 with accent color applied to the titlebar, paint the background of the inactive tabs with the theme color. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.