Closed Bug 1506254 Opened 4 years ago Closed 4 years ago

Task retry does not work for Android 7.0 x86 wpt tasks


(Testing :: General, defect, P1)

Version 3


(firefox-esr60 fixed, firefox65 fixed)

Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed


(Reporter: gbrown, Assigned: gbrown)




(1 file)

Android 4.3 tasks automatically retry on ADBTimeoutError and ADBError but I haven't seen that mechanism working on Android 7.0 x86. Also, kwierso pointed out

I think at least the first one should have retried.
The task definition looks correct:

  "onExitStatus": {
    "purgeCaches": [
    "retry": [
Works for mochitest regardless of platform:

Maybe different output parser for wpt?
(In reply to Geoff Brown [:gbrown] from comment #2)
> Maybe different output parser for wpt?

Yes, that seems to be the issue. The other Android test tasks use DesktopUnittestOutputParser, which checks the retry regex; Android wpt uses StructuredOutputParser, which does not check that regex.
See Also: → 1507560
Priority: -- → P1
Summary: Verify task retry for Android 7.0 x86 tasks → Task retry does not work for Android 7.0 x86 wpt tasks
The DesktopUnittestOutputParser already supports TBPL_RETRY. There's no convenient way to move support to the base class which doesn't know about self.tbpl_status and is currently free of higher level mozharness dependencies.

In addition to detecting retry conditions and setting tbpl_status, we need to be careful not to clobber TBPL_RETRY when doing the summary processing required for TV and similar runs.

Here's an example with retry forced by an ADBError:

and another try run to check that normal success/failure status is generally okay:
Attachment #9026576 - Flags: review?(jmaher)
Comment on attachment 9026576 [details] [diff] [review]
support TBPL_RETRY in structured logging output parser

Review of attachment 9026576 [details] [diff] [review]:

we only have to update ?
Attachment #9026576 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #6)
> we only have to update ?

Yes, I think so.
Pushed by
Support TBPL_RETRY in structured logger, to enable task retry; r=jmaher
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Should this have made the `ERROR - adb get_process_list:` failures trigger a retry, or was comment 0 just kinda hoping it might have been fixed along with the `ls could not be found` case?

Because I rebased onto the merge to m-c that included this patch and I'm still getting failures like that aren't retrying.
Retry will be triggered by "ADBError" or "ADBTimeoutError" in the log, but not this strange get_process_list error -- I filed bug 1509324 for that and will follow up.
You need to log in before you can comment on or make changes to this bug.