1506261 - Convert search-one-offs from a custom element to a plain JS class and initialize it lazily

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

Right now we are doing work to create these nodes in DOMContentLoaded, but they aren't used until the popup is opened. See https://bugzilla.mozilla.org/show_bug.cgi?id=1506237#c1.

There's also been discussion about making this a plain JS class instead of a Custom Element: https://bugzilla.mozilla.org/show_bug.cgi?id=1493536#c6. It might make sense to do that as part of this lazifying.

Comment 1

[Dão Gottwald [::dao]]

Attachment: Bug 1506261 - Convert search-one-offs from a custom element to a plain JS class and initialize it lazily.

Comment 2

[Dão Gottwald [::dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f65e7bada1a69fac78c2cad3a25218603fe6654

Comment 3

[Dão Gottwald [::dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b425a707d06a4ff9b3cd932fc4defdad8b2dc79f

Comment 4

[Dão Gottwald [::dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7427807fce82ac3ad8285b5f0070825ee5f060d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10a5af6d30df
Convert search-one-offs from a custom element to a plain JS class and initialize it lazily. r=bgrins

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing window leaks on OSX debug. CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed&searchStr=browser%2Cchrome%2Cosx&fromchange=f1455bc47683cfb08083e60506a612d190419d1e&tochange=d76f007bee63b3730068f1a5549bd4d6513593c7&selectedJob=211914014

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211914014&repo=autoland&lineNumber=4723

Backout link: https://hg.mozilla.org/integration/autoland/rev/d76f007bee63b3730068f1a5549bd4d6513593c7

Comment 7

[Cosmin Sabou [:CosminS]]

These happen also on 
Linux debug: https://treeherder.mozilla.org/logviewer.html#?job_id=211916214&repo=autoland&lineNumber=16238
Windows debug: https://treeherder.mozilla.org/logviewer.html#?job_id=211918507&repo=autoland&lineNumber=11747

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1106b713fd95
Convert search-one-offs from a custom element to a plain JS class and initialize it lazily. r=bgrins

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1106b713fd95