1506271 - Intermittent browser/base/content/test/general/browser_datachoices_notification.js | A promise chain failed to handle a rejection: win.gBrowser is undefined; can't access its "tabs" property - stack: BG__setSyncAutoconnectDelay@jar:file:

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=210875277&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/LY6zZi3VR1uPJRI2RzNvYg/runs/0/artifacts/public/logs/live_backing.log

18:52:22     INFO - TEST-PASS | browser/base/content/test/general/browser_datachoices_notification.js | Date pref set. - 1541789541518 > -1 - 
18:52:22     INFO - Buffered messages finished
18:52:22     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_datachoices_notification.js | A promise chain failed to handle a rejection: win.gBrowser is undefined; can't access its "tabs" property - stack: BG__setSyncAutoconnectDelay@jar:file:///Z:/task_1541787785/build/application/firefox/browser/omni.ja!/components/nsBrowserGlue.js:637:7
18:52:22     INFO - BG_observe@jar:file:///Z:/task_1541787785/build/application/firefox/browser/omni.ja!/components/nsBrowserGlue.js:755:9
18:52:22     INFO - async*notify@resource://services-common/observers.js:87:5
18:52:22     INFO - onStartup/<@resource://services-sync/service.js:341:7
18:52:22     INFO - Rejection date: Fri Nov 09 2018 18:52:21 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257
18:52:22     INFO - Stack trace:
18:52:22     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:257
18:52:22     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1118
18:52:22     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
18:52:22     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:977
18:52:22     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
18:52:22     INFO - Leaving test bound test_multiple_windows
18:52:22     INFO - GECKO(8436) | MEMORY STAT | vsize 1806MB | vsizeMaxContiguous 131160956MB | residentFast 362MB | heapAllocated 158MB
18:52:22     INFO - TEST-OK | browser/base/content/test/general/browser_datachoices_notification.js | took 1604ms
18:52:22     INFO - GECKO(8436) | ++DOCSHELL 0000024525A48000 == 1 [pid = 1884] [id = {edb142f7-bb4b-4164-ab4b-826f3a8fed9a}]
18:52:22     INFO - GECKO(8436) | ++DOMWINDOW == 1 (0000024525A14400) [pid = 1884] [serial = 1] [outer = 0000000000000000]

Comment 1

[Robert Strong (they/them - no direct email)]

This is the same issue as with bug 1505790. In the case of bug 1505790 it appears that while the previous test was running BG__setSyncAutoconnectDelay was called. Whatever the case, the BG__setSyncAutoconnectDelay code is flakey and at the very least should check if win.gBrowser is defined so other tests don't fail like this.

needinfoing mattn and jaws to see if they can find someone to fix the core problem in BG__setSyncAutoconnectDelay

https://dxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#624

Comment 2

[Intermittent Failures Robot]

1 failures in 3007 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1506271&startday=2018-11-05&endday=2018-11-11&tree=all

Comment 3

[Matthew N. [:MattN]]

Maybe :markh can take a look at this?

Comment 4

[Mark Hammond [:markh] [:mhammond]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> BG__setSyncAutoconnectDelay ... should check if win.gBrowser is defined so
> other tests don't fail like this.

That sounds fine to me - patch incoming.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1506271 - BrowserGlue._setSyncAutoconnectDelay() now checks win.gBrowser before using it. r?MattN

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b691e65265da
BrowserGlue._setSyncAutoconnectDelay() now checks win.gBrowser before using it. r=MattN

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b691e65265da