Closed Bug 1506280 Opened 4 years ago Closed 4 years ago
Improve diagnostics when redirecting functions
The attached patch fixes some issues with reporting and diagnosing problems that happen while installing function redirections at recording/replaying process startup: - Some assertions that can in principle fail have been converted into reported failures that are printed at startup and will lead to a crash report being generated. If we just crash on the assertion failure, no report will be generated as the crash reporter hasn't been set up yet. - Convert some DEBUG-only assertions into release mode assertions, for better checking. - Add a MOZ_RECORD_REPLAY_REDIRECT_SPEW environment variable that can be set to see detailed logging of the redirecting process.
Attachment #9024127 - Flags: review?(lsmyth)
Attachment #9024127 - Flags: review?(lsmyth) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/86591a68c329 Improve diagnostics when redirecting functions, r=lsmyth.
You need to log in before you can comment on or make changes to this bug.