Closed Bug 1506298 Opened Last year Closed Last year

When tokenizing a string containing an escape sequence consisting of U+005C REVERSE SOLIDUS followed by a literal multi-unit code point, properly interpret the whole sequence as representing that multi-unit code point

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(1 file)

Stupid mistake, yay tests.  :-)
Attached patch PatchSplinter Review
A handful of existing tests caught this, e.g. test262/language/literals/string/S7.8.4_A4.2_T7.js, so no need for a new one.
Attachment #9024144 - Flags: review?(arai.unmht)
Blocks: 1504947
Attachment #9024144 - Flags: review?(arai.unmht) → review+
Priority: -- → P1
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba4426e7a59
When tokenizing a string containing an escape sequence consisting of U+005C REVERSE SOLIDUS followed by a literal multi-unit code point, properly interpret the whole sequence as representing that multi-unit code point -- not as representing the first code unit of that sequence.  #oops  r=jorendorff
https://hg.mozilla.org/mozilla-central/rev/1ba4426e7a59
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.