Closed
Bug 1506310
Opened 4 years ago
Closed 4 years ago
Add support for optionally_keyed_by by-release-type to mozharness extra-options
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(firefox-esr60 fixed, firefox65 verified)
VERIFIED
FIXED
mozilla65
People
(Reporter: bc, Assigned: tomprince)
References
Details
(Whiteboard: [stockwell fixed])
Attachments
(2 files)
After discussing the proposed patch in bug 1499352 attachment 9023986 [details] [diff] [review] with tomprince, we decided on the better approach would be to add the ability to optionally key the mozharness extra-options by release-type. It would support the ability to specify extra-options like: raptor-tp6-1-firefox: description: "Raptor tp6-1 on Firefox" try-name: raptor-tp6-1-firefox treeherder-symbol: Rap(tp6-1) run-on-projects: built-projects max-run-time: 1800 mozharness: extra-options: by-release-type: beta: - --test=raptor-tp6-1 - --is--release-build release.*: - --test=raptor-tp6-1 - --is--release-build esr.*: - --test=raptor-tp6-1 - --is--release-build default: - --test=raptor-tp6-1 Though, I wonder if projects would be an equivalent choice. In the light of how verbose this would be and the fact it would be required on every test description I think I would just end up using if config.params['project'] in ('mozilla-beta', 'mozilla-release') or \ config.params['project'].startswith('mozilla-esr'): extra_options.append('--is-release-build') in https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests.py#508 Feel free to wontfix this.
Flags: needinfo?(mozilla)
Assignee | ||
Comment 2•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cccda5cba8a853d94ed3f78349461010728ed4c4
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment 6•4 years ago
|
||
Since all occurrences are only on try based on OF, removing disable recommended tag.
Whiteboard: [stockwell disable-recommended]
Comment hidden (Intermittent Failures Robot) |
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/a1fc429db01a Remove unused branch_name passed from taskcluster to talos; r=jmaher https://hg.mozilla.org/integration/autoland/rev/b1bec3572f17 Determine whether builds under test need signed extenions by release type; r=bc,ahal
Comment 9•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a1fc429db01a https://hg.mozilla.org/mozilla-central/rev/b1bec3572f17
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•4 years ago
|
Assignee: nobody → mozilla
Comment 10•4 years ago
|
||
This is fixed in today's beta simulations: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9874af9fcaa8b20952dc65c4869a3ce1b0c0a01e https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=c301160f061b04ea32ff02956869ee2b6f242765
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Reporter | ||
Comment 11•4 years ago
|
||
Thanks for taking this on Tom! I appreciate your proactive work on this.
Flags: needinfo?(mozilla)
Reporter | ||
Comment 12•4 years ago
|
||
Tom: It appears --is-release-build is being set even for mozilla-central builds: <https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215084358&repo=mozilla-central&lineNumber=64-73> Is there something different we need to do in order to only do it for beta, release or esr?
Flags: needinfo?(mozilla)
Comment 13•4 years ago
|
||
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/f2833f7caddf Fix typo in determining whether builds under test need signed extenions by release type; r=me
Assignee | ||
Comment 14•4 years ago
|
||
There was a typo in the code to evaluate `require-signed-extensions`.
Flags: needinfo?(mozilla)
Comment 15•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2833f7caddf
Reporter | ||
Comment 16•4 years ago
|
||
Hah! I don't know how many times I must of looked at that patch and *never* saw it. Looks good now. Thanks!
Assignee | ||
Comment 17•4 years ago
|
||
It took me grepping for the code that handled the 'by-release-type` and not finding it, to figure out that it was a typo. 😀
Reporter | ||
Updated•4 years ago
|
Whiteboard: [stockwell disable-recommended] → [stockwell fixed]
Assignee | ||
Comment 18•4 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/8c64f4130d86 https://hg.mozilla.org/releases/mozilla-esr60/rev/57c6bca5255e https://hg.mozilla.org/releases/mozilla-esr60/rev/9bbffcaaefb9
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•