Closed Bug 1506454 Opened Last year Closed Last year

Add JS API to make [[PromiseIsHandled]] internal slot in Promise accessible in Spider Monkey

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Version:
65 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: cybai, Assigned: cybai)

Details

Attachments

(1 file)

Bug 1506454 - Add JS API to make [[PromiseIsHandled]] internal slot in Promise accessible in Spider Monkey
47 bytes, text/x-phabricator-request
Details | Review 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

When I worked on `unhandledrejection` event for Servo, I found this internal slot was missing in SM. So, I've sent a PR to mozjs in https://github.com/servo/mozjs/pull/150 .

I'll send a patch for this issue.


Actual results:

The `GetPromiseIsHandled` internal slot is missing


Expected results:

We should have `GetPromiseIsHandled` internal slot in Promise
Component: Untriaged → JavaScript Engine
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → cyb.ai.815
Thanks! r+ed with some comments :)
arai, thanks for the review! I just updated the PR but I'm still not so familiar with hg. So I didn't squash the commits, if you think squashing commits is required, please let me know, I will try it again, thanks!
Summary: Introduce GetPromiseIsHandled internal slot to Promise for Spider Monkey → Add JS API to make GetPromiseIsHandled internal slot in Promise accessible in Spider Monkey
Attachment #9024290 - Attachment description: Bug 1506454 - Introduce GetPromiseIsHandled internal slot for Promise → Bug 1506454 - Add JS API to make GetPromiseIsHandled internal slot in Promise accessible in Spider Monkey
Oh! I found I just used wrong command to update phabricator in my first try for squash.
And now I have squashed the commits successfully!
Attachment #9024290 - Attachment description: Bug 1506454 - Add JS API to make GetPromiseIsHandled internal slot in Promise accessible in Spider Monkey → Bug 1506454 - Add JS API to make [[PromiseIsHandled]] internal slot in Promise accessible in Spider Monkey
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/0dc9d562a03a
Add JS API to make [[PromiseIsHandled]] internal slot in Promise accessible in Spider Monkey r=arai
Summary: Add JS API to make GetPromiseIsHandled internal slot in Promise accessible in Spider Monkey → Add JS API to make [[PromiseIsHandled]] internal slot in Promise accessible in Spider Monkey
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/0dc9d562a03a
Status: NEW → RESOLVED
Closed: Last year
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.