Closed Bug 1506455 Opened 3 years ago Closed 3 years ago

Changes panel should stay left to right even in RTL builds

Categories

(DevTools :: Inspector, defect, P2)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: pbro, Assigned: rcaliman)

References

Details

Attachments

(2 files)

Screenshot 2018-11-11 at 15.44.27.png
47.15 KB, image/png
Details
Bug 1506455 - Enforce LTR code on RTL layout in Changes panel r=pbro
47 bytes, text/x-phabricator-request
Details | Review 
STR:
- use a RTL build of Firefox Nightly
- open the inspector
- make CSS changes in the rule view
- look at the Changes panel (see screenshot)

Expected: changes are displayed like CSS rule in the rules-view, so should stay left-to-right, because that's how CSS writes, whatever the locale.

Actual: the changes are trying to display themselves right to left, but that doesn't make much sense since they are displayed as CSS.
By adding something like this to the CSS, the UI reverts to LTR:

#sidebar-panel-changes .rule {
    direction: ltr;
}
Blocks: 1503920
No longer blocks: track-changes
Priority: -- → P2
Duplicate of this bug: 1506270
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/215654db940b
Enforce LTR code on RTL layout in Changes panel r=pbro
https://hg.mozilla.org/mozilla-central/rev/215654db940b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.