Closed Bug 1506470 Opened Last year Closed Last year

TEST-UNEXPECTED-FAIL | [snip]/mozmill/content-tabs/test-lwthemes.js

Categories

(Thunderbird :: General, enhancement)

Product:
Thunderbird
Component:
General
Type:
enhancement
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 65.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

1506470-currentThemeForDisplay.patch
1.10 KB, patch
aceman
: review+
Details | Diff | Splinter Review 
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/content-tabs/test-lwthemes.js | test-lwthemes.js::test_lightweight_themes_install
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/content-tabs/test-lwthemes.js | test-lwthemes.js::test_lightweight_themes_install_and_undo

M-C last good: e9ff3fec51d3de454f607b69b4acddc2a8
M-C first bad: 39dba5141dd90c70a861299459d418d230
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e9ff3fec51d3de454f607b69b4acddc2a8&tochange=39dba5141dd90c70a861299459d418d230

Perhaps related to bug 1429488 of which we've already ported some in bug 1506411.

The other notification-related failures here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=211041410&revision=37233a992def692093f85e6b88860bc500869634
are already fixed in bug 1505288.

https://taskcluster-artifacts.net/bgd_FVYDSV-WIu4DD955bg/0/public/logs/live_backing.log

EXCEPTION: currentLwTheme(...) is undefined; can't access its "id" property
EXCEPTION: mc.tabmail.selectedTab.panel is undefined; can't access its "querySelector" property

Aceman, any free cycles for this?
Flags: needinfo?(acelists)
Hmm, similar fix to https://hg.mozilla.org/comm-central/rev/5cdc6b2fd2fde4e6f80a3b14d79a3de096ebf98f

I need to build locally first to see whether the test passes now.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Flags: needinfo?(acelists)
Attachment #9024311 - Flags: review?(acelists)
Test passes with the patch.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1499532bcad2
Port bug 1429488, part 5, take 2: s/currentThemeForDisplay/currentThemeWithPersistedData/. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Comment on attachment 9024311 [details] [diff] [review]
1506470-currentThemeForDisplay.patch

Review of attachment 9024311 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #9024311 - Flags: review?(acelists) → review+
You need to log in before you can comment on or make changes to this bug.