Port bug 1503342 - Rename richlistbox.children to richlistbox.itemChildren

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jorgk, Assigned: darktrojan)

Tracking

Trunk
Thunderbird 65.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This
https://hg.mozilla.org/mozilla-central/rev/71321c967598#l22.101
-      <property name="children" readonly="true">
+      <property name="itemChildren" readonly="true">

looks like it will break a lot of things.

Since "children" is such a vanilla name, it's hard to tell which one need replacing :-(

https://searchfox.org/comm-central/search?q=.children&case=false&regexp=false&path=
I'll make a start on this, there's definitely a few that need changing.
Not as many as expected. I haven't tried the test because my tree is not current.
Thanks, I can do another try, but the previous one was all green, so hard to tell what this patch will fix. Sure, something in filters, chat and a test ;-)
Comment on attachment 9024382 [details] [diff] [review]
1506535-listbox-children-1.diff

Review of attachment 9024382 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/test/mozmill/attachment/test-attachment.js
@@ +373,5 @@
>  
>    // We can just click on the first element, but the second one needs a
>    // ctrl-click (or cmd-click for those Mac-heads among us).
> +  mc.click(new elib.Elem(attachmentList.itemChildren[0]), 5, 5);
> +  EventUtils.synthesizeMouse(attachmentList.itemChildrens[1], 5, 5,

Childrens?
But I do not see where itemChildren is defined. It is not done in that m-c patch.
Yes, I did search where that code change from comment 0 is done but didn't spot it in the m-c patch. But I see it now.
dxr and searchfox do not show it yet in the tree.
Comment on attachment 9024382 [details] [diff] [review]
1506535-listbox-children-1.diff

Looks good apart from the spurious "s" that Aceman pointed out. No idea whether this is complete. If you look for |list.*\.children| this is all that DXR finds:
https://dxr.mozilla.org/comm-central/search?q=regexp%3Alist.*%5C.children+path%3Acomm%2F&redirect=false
Searchfox doesn't see the chat match :-(
https://searchfox.org/comm-central/search?q=list.*%5C.children&case=false&regexp=true&path=

I'll land this after the next merge and we can follow up with more.

Try:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=3cab57531568e5b89a26b3173447e3e81cef393c
Attachment #9024382 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8ebed1915704
Port bug 1503342: Change uses of richlistbox.children to richlistbox.itemChildren. r=jorgk
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
(In reply to :aceman from comment #5)
> > +  mc.click(new elib.Elem(attachmentList.itemChildren[0]), 5, 5);
> > +  EventUtils.synthesizeMouse(attachmentList.itemChildrens[1], 5, 5,
> 
> Childrens?

No idea how that happened!
Assignee: nobody → geoff
You need to log in before you can comment on or make changes to this bug.