Closed Bug 1506545 Opened Last year Closed Last year

Instantiate content process Target via the ContentProcessTargetFront rather than its form

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

(Whiteboard: dt-fission)

Attachments

(2 files)

For now, the Target for the browser content toolbox is instantiated via the form of the ContentProcessTargetActor.
Instead it should be instantiated via its front, by passing the front as Target constructor argument.

https://searchfox.org/mozilla-central/rev/06d5d5ae4396be85f26e8548323ee6c12e7bce4e/devtools/client/framework/devtools-browser.js#321-327
Front.actor custom implementation is only used from Front class and doesn't match Pool's one behavior.
Front users would expect to see the one from Pool as it inherits from it.

MozReview-Commit-ID: 8plo2K5kEWq
MozReview-Commit-ID: EE4d0YULRBU

Depends on D11614
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68818faecaa4
Stop overloading Pool.actor from Front class. r=yulia
https://hg.mozilla.org/integration/autoland/rev/0513507532c5
Instantiate Target for ContentProcessTargetActor via its front. r=yulia
https://hg.mozilla.org/mozilla-central/rev/68818faecaa4
https://hg.mozilla.org/mozilla-central/rev/0513507532c5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.