1506546 - Instantiate addon Target via the AddonTargetFront rather than its form

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

For now, the Target for the add-on toolboxes are instantiated via the form of the AddonTargetActor.
Instead it should be instantiated via its front, by passing the front as Target constructor argument.

The Front is being instantiated late, within Target.attach:
https://searchfox.org/mozilla-central/source/devtools/client/framework/target.js#585

Instead, callsites creating a Target object should create the front and pass it as Target constructor argument. Then, Target.attach should only call front.attach rather than creating the front.
Ideally, the front should be created by protocol.js automatic marshalling and be returned by RootFront.listAddons.

Comment 1

[Alexandre Poirot [:ochameau]]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=32ec38d71980dec462d153b6f439fdb87845ce2a

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506546 - Refactor getAddonActorForId test helper.

MozReview-Commit-ID: A7JxzO7rhhe

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506546 - Change the spec type of listAddons and accomodate using the front rather than the form.

MozReview-Commit-ID: 4MAjszUiGUZ

Depends on D12573

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506546 - Implement RootFront.getAddon and use it to retrieve a single AddonTargetFront.

MozReview-Commit-ID: nWTkfbF9qb

Depends on D12574

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506546 - Refactor listAddons call sites.

Adapt to the new returned value of listAddons
and also always call it from RootFront instead of DebuggerClient.
Fix the spec in order to expose reload on the front (it was a miss from a previous patch).

MozReview-Commit-ID: AQ5EOQEqnxX

Depends on D12575

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506546 - Refactor about:debuggings.

I did a dedicated patch for converting both about:debuggings as it is slightly more
complex as we have to tweak redux data, wrappers, mocks.
This patch also convert a manual "reload" request being done by about:debugging
and instead use protocol.js front to do it.
Also, I moved isLegacyTemporaryExtension to the front as it depends on accessing the form
and it should be better to keep form processing to the fronts, if possible.

MozReview-Commit-ID: 16qZkuCBp9b

Depends on D12576

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506546 - Use protocol.js to fetch WebExtension target actor.

We were dipatching the "connect" request manually, whereas we should be using
protocol.js specifications. It also help getting rid of another use of "form"
instead of "front"/activeTab in Target class.

MozReview-Commit-ID: IOH4mDprAVL

Depends on D12577

Comment 8

[Alexandre Poirot [:ochameau]]

This depends on bug 1507429 as it makes devtools/server/tests/unit/test_addon_events.js permafail.

Comment 9

[Alexandre Poirot [:ochameau]]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=213444431&revision=740441c6e8cd8771e4d5a4c00b6010686050ff0c

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1506546 - Remove unused AddonClient module.

MozReview-Commit-ID: ExKMirBQJ3K

Depends on D12578

Comment 11

[Alexandre Poirot [:ochameau]]

New try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c769863fce1d69ea5fece61adfddb1ac6d577625

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23ad29cb776e
Refactor getAddonActorForId test helper. r=yulia
https://hg.mozilla.org/integration/autoland/rev/7b75250a4f12
Change the spec type of listAddons and accomodate using the front rather than the form. r=yulia
https://hg.mozilla.org/integration/autoland/rev/a293a37483b9
Implement RootFront.getAddon and use it to retrieve a single AddonTargetFront. r=yulia
https://hg.mozilla.org/integration/autoland/rev/7d8e650e25c2
Refactor listAddons call sites. r=yulia
https://hg.mozilla.org/integration/autoland/rev/00fe26234b3d
Refactor about:debuggings. r=yulia,jdescottes
https://hg.mozilla.org/integration/autoland/rev/8972a2f14015
Use protocol.js to fetch WebExtension target actor. r=yulia
https://hg.mozilla.org/integration/autoland/rev/fbe3f2183f32
Remove unused AddonClient module. r=jdescottes

Comment 13

[Andreea Pavel [:apavel]]

Backed out for failing devtools at devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_system_addons.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=214100034&revision=fbe3f2183f32134a867db07f07352fb33428ea3c

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=214100034&repo=autoland&lineNumber=1530

Backout: https://hg.mozilla.org/integration/autoland/rev/c19baae766e96ffbc7bf20534e1ba62b64871fe3

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67c951597bd9
Refactor getAddonActorForId test helper. r=yulia
https://hg.mozilla.org/integration/autoland/rev/e5fb062f20f8
Change the spec type of listAddons and accomodate using the front rather than the form. r=yulia
https://hg.mozilla.org/integration/autoland/rev/da5ade7a2726
Implement RootFront.getAddon and use it to retrieve a single AddonTargetFront. r=yulia
https://hg.mozilla.org/integration/autoland/rev/abfeab4a1d65
Refactor listAddons call sites. r=yulia
https://hg.mozilla.org/integration/autoland/rev/9abf7054a03e
Refactor about:debuggings. r=yulia,jdescottes
https://hg.mozilla.org/integration/autoland/rev/24751811ee6e
Use protocol.js to fetch WebExtension target actor. r=yulia
https://hg.mozilla.org/integration/autoland/rev/b7c7c49fcaa8
Remove unused AddonClient module. r=jdescottes

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/67c951597bd9
https://hg.mozilla.org/mozilla-central/rev/e5fb062f20f8
https://hg.mozilla.org/mozilla-central/rev/da5ade7a2726
https://hg.mozilla.org/mozilla-central/rev/abfeab4a1d65
https://hg.mozilla.org/mozilla-central/rev/9abf7054a03e
https://hg.mozilla.org/mozilla-central/rev/24751811ee6e
https://hg.mozilla.org/mozilla-central/rev/b7c7c49fcaa8