Closed Bug 1506653 Opened Last year Closed 11 months ago

pageAction needs to support showInPrivateBrowsing

Categories

(WebExtensions :: Frontend, enhancement, P1)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

CUI widgets have showInPrivateBrowsing which defaults to true.  This allows us to turn off browserAction.  PageActions.jsm do not appear to have a similar flag.  This is to cover supporting both that and ext-pageAction in webextensions.
Assignee: nobody → mixedpuppy
Priority: -- → P1
Depends on: 1486274
No longer depends on: 1486274
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2d0a91485b6b
support disabling page action for private windows, r=Gijs
https://hg.mozilla.org/mozilla-central/rev/2d0a91485b6b
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.