Closed Bug 1506656 Opened 2 years ago Closed 2 years ago

ReadableStream controller constructors should throw unconditionally

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

They already do, as it's impossible for content to get hold of a stream with no controller, which is the only kind of object our existing code would accept. But the spec now just directly says the constructor always throws, and the code should match it.
They already do, as it's impossible for content to get hold of a stream with no controller,
which is the only kind of object our existing code would accept. But the spec is now more
direct, and the code should match it.
This renames the other CreateReadableByteStreamController signature, since the
two seem different enough to warrant distinct names.

Depends on D11679
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/629234236ee4
Part 1: ReadableStream controller constructors should throw unconditionally. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/ff90a2f2c654
Part 2: Silence a dead code warning. r=jwalden
https://hg.mozilla.org/mozilla-central/rev/629234236ee4
https://hg.mozilla.org/mozilla-central/rev/ff90a2f2c654
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.