1506656 - ReadableStream controller constructors should throw unconditionally

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Jason Orendorff [:jorendorff]]

They already do, as it's impossible for content to get hold of a stream with no controller, which is the only kind of object our existing code would accept. But the spec now just directly says the constructor always throws, and the code should match it.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1506656 - Part 1: ReadableStream controller constructors should throw unconditionally. r?jwalden

They already do, as it's impossible for content to get hold of a stream with no controller,
which is the only kind of object our existing code would accept. But the spec is now more
direct, and the code should match it.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1506656 - Part 2: Silence a dead code warning. r?jwalden

This renames the other CreateReadableByteStreamController signature, since the
two seem different enough to warrant distinct names.

Depends on D11679

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/629234236ee4
Part 1: ReadableStream controller constructors should throw unconditionally. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/ff90a2f2c654
Part 2: Silence a dead code warning. r=jwalden

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/629234236ee4
https://hg.mozilla.org/mozilla-central/rev/ff90a2f2c654